-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't error on already mapped tokens #1420
Conversation
Diff for pulumi-random with merge commit 859afc4 |
Diff for pulumi-azuread with merge commit 859afc4 |
8f2f286
to
1b52fa6
Compare
Diff for pulumi-random with merge commit d1a7b78 |
Diff for pulumi-azuread with merge commit d1a7b78 |
Codecov Report
@@ Coverage Diff @@
## master #1420 +/- ##
==========================================
- Coverage 61.87% 57.84% -4.03%
==========================================
Files 182 282 +100
Lines 32708 39476 +6768
==========================================
+ Hits 20238 22835 +2597
- Misses 11332 15307 +3975
- Partials 1138 1334 +196
... and 103 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm a bit miffed did not catch this at plan/review time. Having ComputeTokens never override the tokens manually specified is a very important property as this is our "user override" story - actually can you elaborate a bit how did this behave before the PR?
Would there be a situation where this change would cause a change in token allocation? As opposed to simply turning failing programs into working programs? |
Before this PR, we would error on missing modules for already mapped tokens:
I don't expect so. We will not experience any mapping changes from this PR. It is always possible that user's will rely on the incorrect behavior, but I can't imagine a sensible usage that will break with this change. |
Token mapping should not error when it is unable to map a token that was mapped manually. Apparently, this is not a common scenario, but I encountered it as part of pulumi/pulumi-spotinst#436.
Fixes #1421