Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check multiple docs locations #1462

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Oct 23, 2023

Fixes #1461 and unblocks pulumi/pulumi-okta#414.

@iwahbe iwahbe self-assigned this Oct 23, 2023
// Other errors (such as permission errors) indicate a problem
// with the host system, and should be reported.
return nil, fmt.Errorf("%s: %w", location, err)
for _, prefix := range locationPrefix {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change within this loop is the extra layer of indentation.

@iwahbe iwahbe requested a review from a team October 23, 2023 18:11
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #1462 (00b63cb) into master (9f8ebfe) will decrease coverage by 4.02%.
The diff coverage is 48.83%.

@@            Coverage Diff             @@
##           master    #1462      +/-   ##
==========================================
- Coverage   61.92%   57.91%   -4.02%     
==========================================
  Files         183      283     +100     
  Lines       32758    39537    +6779     
==========================================
+ Hits        20286    22898    +2612     
- Misses      11333    15302    +3969     
- Partials     1139     1337     +198     
Files Coverage Δ
pkg/tfgen/docs.go 73.80% <ø> (+0.86%) ⬆️
pkg/tfgen/source.go 45.20% <48.83%> (+7.70%) ⬆️

... and 103 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, long needed fixing!

@iwahbe iwahbe merged commit ef0b557 into master Oct 23, 2023
7 checks passed
@iwahbe iwahbe deleted the iwahbe/1461/check-multiple-docs-locations branch October 23, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs are not picked up from website and docs
3 participants