Demonstrate optional+computed #1901
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1901 +/- ##
==========================================
- Coverage 60.25% 60.25% -0.01%
==========================================
Files 328 328
Lines 44322 44322
==========================================
- Hits 26706 26705 -1
- Misses 16120 16121 +1
Partials 1496 1496 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to double-check how pulumi projects Optional+Computed properties. These properties may be omitted by the user program (hence Optional) but still may be set by the provider (hence Computed).
Looks like currently bridge maps this to a non-required input (definitely right) but a required output. I wonder if TF model requires the provider to populate these properties or allows nulls.
https://developer.hashicorp.com/terraform/plugin/sdkv2/schemas/schema-behaviors#computed a bit inconclusive but my intuition is that it's possible for a provider to leave Computed+Optional as unset.