Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Enable PlanResourceChange by default #1963

Closed
wants to merge 2 commits into from

Conversation

VenelinMartinov
Copy link
Contributor

Related to #1962

Adds a env var to enable PlanResourceChange for all resources.

@VenelinMartinov VenelinMartinov marked this pull request as draft May 13, 2024 14:44
@VenelinMartinov
Copy link
Contributor Author

Actually, I don't really want to merge this - I'll just default enable and run downstream tests off the branch.

@VenelinMartinov VenelinMartinov changed the title Add plan resource change env var [DO NOT MERGE] Enable PlanResourceChange by default May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 60.55%. Comparing base (d57cd0e) to head (bbf9da5).

❗ Current head bbf9da5 differs from pull request most recent head 3242c86. Consider uploading reports for the commit 3242c86 to get more accurate results

Files Patch % Lines
pkg/tfshim/sdk-v2/provider.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1963      +/-   ##
==========================================
- Coverage   60.56%   60.55%   -0.02%     
==========================================
  Files         331      331              
  Lines       44726    44728       +2     
==========================================
- Hits        27090    27084       -6     
- Misses      16113    16121       +8     
  Partials     1523     1523              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented May 13, 2024

@VenelinMartinov
Copy link
Contributor Author

Actually, not enough failures probably, I'll prioritise #1849 first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant