Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross test fix required empty blocks #1995

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented May 19, 2024

We were generating wrong HCL and Pulumi code in the cross test framework for empty required lists of other collections. This should fix both.

TF errors:

│ Error: Insufficient d2f0 blocks
│
│   on test.tf line 1, in resource "crossprovider_testres" "example":
│    1: resource "crossprovider_testres" "example" {
│
│ At least 1 "d2f0" blocks are required.

Pulumi errors:

Error: crossprovider:index:TestRes is not assignable from {}
  Cannot assign '{}' to 'crossprovider:index:TestRes':
    d3f0: Missing required property 'd3f0'

Also adds a test case for nested maxItemsOne properties - the second level empty test case is impossible to match because of the reduced information in the pulumi representation, right?

@VenelinMartinov VenelinMartinov changed the base branch from master to vvm/cross_test_set_single_nested_blocks May 19, 2024 21:14
@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented May 22, 2024

superseded by #2011

EDIT: wrong PR

@VenelinMartinov
Copy link
Contributor Author

Superseded by #2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant