pf resources show diff for empty map #2165
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re pulumi/pulumi-aws#4080 I've noticed different behavior between sdkv2 and pf resources. Sometimes if you do not provide a value for a map property it will write an empty value to the outputs (i.e. `{ "tagsAll": {} }`). When diff is called, the `olds` show the empty object value and the news show no entry at all. sdkv2 resources handle this and do not display any diff whereas pf resources show a diff.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2165 +/- ##
=======================================
Coverage 60.64% 60.64%
=======================================
Files 350 350
Lines 45925 45925
=======================================
Hits 27852 27852
Misses 16533 16533
Partials 1540 1540 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re pulumi/pulumi-aws#4080
I've noticed different behavior between sdkv2 and pf resources.
Sometimes if you do not provide a value for a map property it will write
an empty value to the outputs (i.e.
{ \"tagsAll\": {} }).When diff is called, the
oldsshow the empty object value and the newsshow no entry at all. sdkv2 resources handle this and do not display any
diff whereas pf resources show a diff.