Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: repro aws-4223 #2182

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: repro aws-4223 #2182

wants to merge 1 commit into from

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Jul 15, 2024

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.64%. Comparing base (a2fd8df) to head (2fcdc94).

Files Patch % Lines
pkg/tests/cross-tests/diff_check.go 42.85% 3 Missing and 1 partial ⚠️
pkg/tests/cross-tests/exec.go 60.00% 2 Missing ⚠️
pkg/tests/internal/pulcheck/pulcheck.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2182      +/-   ##
==========================================
- Coverage   60.65%   60.64%   -0.01%     
==========================================
  Files         350      350              
  Lines       45930    45943      +13     
==========================================
+ Hits        27859    27864       +5     
- Misses      16532    16538       +6     
- Partials     1539     1541       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjeffryes mjeffryes modified the milestone: 0.107 Jul 24, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Sep 27, 2024

@VenelinMartinov @iwahbe this is an interesting issue that might be persisting post PlanResourceChange refactor. Still open in AWS I think. Curious if you any of you are interested in diving deeper on this with me.

@VenelinMartinov
Copy link
Contributor

Yeah, it looks interesting. Would be interesting to see it in a cross-test - would TF act differently here? Would be happy to take a look.

@t0yv0
Copy link
Member Author

t0yv0 commented Sep 27, 2024

Yes "Terraform does not have this issue".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants