Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HasPulumiProviderName check for use in terraform converter. #2483

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brandonpollack23
Copy link
Contributor

This will be used in GetProviderInfo in converter-terraform.

In that case, the main.tf package info will be used to get the repo and package in the open tofu repositories (as opposed to just the raw name) to be passed to the GetMapper command.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.18%. Comparing base (678d0fd) to head (b699069).

Files with missing lines Patch % Lines
pkg/tf2pulumi/il/plugin_info.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2483      +/-   ##
==========================================
- Coverage   57.19%   57.18%   -0.01%     
==========================================
  Files         372      372              
  Lines       51243    51246       +3     
==========================================
  Hits        29307    29307              
- Misses      20340    20343       +3     
  Partials     1596     1596              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t0yv0
Copy link
Member

t0yv0 commented Oct 15, 2024

Hi @brandonpollack23 we're trying to deprecate and remove pkg/tf2pulumi so that https://github.com/pulumi/pulumi-converter-terraform does not depend on the bridge. Would that be possible? Or perhaps this PR is needed as part of that larger change?

@t0yv0
Copy link
Member

t0yv0 commented Oct 15, 2024

Looks like some balls got dropped on this but #2004 was one attempt. This decoupling can also be instrumental in #1922

#2037 completed internally for Pulumi-managed providers but we still need to do a small rollout to external stakeholders to make this the default behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants