-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement runCreateInputCheck
in terms of Create
#2503
Conversation
stack-info: PR: #2503, branch: iwahbe/stack/4
stack-info: PR: #2503, branch: iwahbe/stack/4
905f6f7
to
e98e8d3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## iwahbe/stack/2 #2503 +/- ##
==================================================
+ Coverage 62.50% 62.60% +0.10%
==================================================
Files 381 381
Lines 51335 51318 -17
==================================================
+ Hits 32088 32130 +42
+ Misses 17432 17374 -58
+ Partials 1815 1814 -1 ☔ View full report in Codecov by Sentry. |
stack-info: PR: #2503, branch: iwahbe/stack/4
stack-info: PR: #2503, branch: iwahbe/stack/4
c249217
to
9f99778
Compare
stack-info: PR: #2503, branch: iwahbe/stack/4
@@ -103,17 +106,49 @@ func Create( | |||
assertCtyValEqual(t, "RawConfig", tfResult.data.GetRawConfig(), puResult.data.GetRawConfig()) | |||
assertCtyValEqual(t, "RawPlan", tfResult.data.GetRawPlan(), puResult.data.GetRawPlan()) | |||
assertCtyValEqual(t, "RawState", tfResult.data.GetRawState(), puResult.data.GetRawState()) | |||
|
|||
for k := range resource { | |||
// TODO: make this recursive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean here? How can we get to 100%?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember right, we are comparing some eeky structures here coming from the TFSDK, these structures resist directly comparing for equality but this is something we need for the purposes of the tests. It is a little tedious to get right but sounds like it should be doable within an hour or two. Am I understanding right? Need a hand here perhaps?
9f99778
to
dcec1ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like my comments are out of scope for the refactor.
stack-info: PR: #2503, branch: iwahbe/stack/4
dcec1ab
to
55b8bca
Compare
563065f
to
4bd2817
Compare
stack-info: PR: #2503, branch: iwahbe/stack/4
55b8bca
to
df19353
Compare
df19353
to
e43d020
Compare
Stacked PRs:
runCreateInputCheck
in terms ofCreate
#2503crosstests.Create
#2501Implement
runCreateInputCheck
in terms ofCreate