Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF re-plan in Diff after detecting a replace #2673

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

VenelinMartinov
Copy link
Contributor

No description provided.

@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Nov 26, 2024

This change is part of the following stack:

Change managed by git-spice.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 58.62069% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.46%. Comparing base (1aa2e64) to head (3a0c57a).

Files with missing lines Patch % Lines
pkg/pf/tfbridge/provider_diff.go 58.62% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2673      +/-   ##
==========================================
+ Coverage   69.44%   69.46%   +0.01%     
==========================================
  Files         301      301              
  Lines       38626    38641      +15     
==========================================
+ Hits        26824    26841      +17     
+ Misses      10277    10274       -3     
- Partials     1525     1526       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_tests_computed_forcenew branch from 4eeafda to 7f1830a Compare November 27, 2024 11:00
@VenelinMartinov VenelinMartinov force-pushed the vvm/diff_replan_on_replace branch from 60b5091 to c12b01e Compare November 27, 2024 11:00
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_diff_tests_computed_forcenew branch from 7f1830a to 43cc58d Compare November 27, 2024 11:22
@VenelinMartinov VenelinMartinov force-pushed the vvm/diff_replan_on_replace branch from c12b01e to c0068a3 Compare November 27, 2024 11:22
Base automatically changed from vvm/sdkv2_diff_tests_computed_forcenew to master November 27, 2024 12:45
@VenelinMartinov VenelinMartinov force-pushed the vvm/diff_replan_on_replace branch from c0068a3 to 3a0c57a Compare November 27, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant