go.mod: Tidy with Go 1.19 #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinav
added
the
impact/no-changelog-required
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Aug 1, 2023
Runs `go mod tidy` with -go=1.19 on the go.mod for the project. Note that as of Go 1.20, the `go` directive is **not** the minimum required Go version. It's the version of the toolchain we developed against. This is changing in Go 1.21. The `-compat` flag specifies which version of Go the go.mod file needs to be compatible with. By default, this is one release behind the `-go` flag (or `go` directive). So we don't need to specify it manually. Lastly, this deletes the `go mod tidy` in the test job. Only the lint job should bbe modifying the go.mod to ensure that the go.mod is up to date.
|
Oops. This was not intended to be merged into the other branch. |
abhinav
added a commit
that referenced
this pull request
Aug 1, 2023
Runs `go mod tidy` with -go=1.19 on the go.mod for the project. Note that as of Go 1.20, the `go` directive is **not** the minimum required Go version. It's the version of the toolchain we developed against. This is changing in Go 1.21. The `-compat` flag specifies which version of Go the go.mod file needs to be compatible with. By default, this is one release behind the `-go` flag (or `go` directive). So we don't need to specify it manually. Lastly, this deletes the `go mod tidy` in the test job. Only the lint job should bbe modifying the go.mod to ensure that the go.mod is up to date. (This is a copy of #471, which was accidentally merged into #474.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs
go mod tidywith -go=1.19 on the go.mod for the project.Note that as of Go 1.20, the
godirective is notthe minimum required Go version.
It's the version of the toolchain we developed against.
This is changing in Go 1.21.
The
-compatflag specifies which version of Go the go.mod fileneeds to be compatible with.
By default, this is one release behind the
-goflag(or
godirective).So we don't need to specify it manually.
Lastly, this deletes the
go mod tidyin the test job.Only the lint job should bbe modifying the go.mod
to ensure that the go.mod is up to date.