-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin(language, converter): Respond to SIGINT #501
Conversation
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
// | ||
// The returned channel is used to notify the server that it should | ||
// stop serving and exit. | ||
ctx, cancel := signal.NotifyContext(context.Background(), os.Interrupt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need a defer'd cancel() // dregister the interrupt handler
here like in the converter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Derp, we do. Good catch. Fixed
Shut the plugin down gracefully when a SIGINT or CTRL_BREAK signal is received. Related: - pulumi/pulumi#13809 - pulumi/pulumi-yaml#501 Refs pulumi/pulumi#9780
Shut the plugin down gracefully when a SIGINT or CTRL_BREAK signal is received. Related: - pulumi/pulumi#13809 - pulumi/pulumi-yaml#501 - pulumi/pulumi-dotnet#172 Refs pulumi/pulumi#9780
Configures the language plugin binary to shut down the plugin RPC server when SIGINT is received. This will help the binary exit cleanly when it's time to shut down. This functionality was added in pulumi/pulumi#13795. pulumi/pulumi#13809 contains a similar change for Go, Python, and Node.
01c5139
to
48cab9c
Compare
Shut the plugin down gracefully when a SIGINT or CTRL_BREAK signal is received. Related: - pulumi/pulumi#13809 - pulumi/pulumi-yaml#501 Refs pulumi/pulumi#9780
Shut the plugin down gracefully when a SIGINT or CTRL_BREAK signal is received. Related: - pulumi/pulumi#13809 - pulumi/pulumi-yaml#501 - pulumi/pulumi-dotnet#172 Refs pulumi/pulumi#9780
Shut the plugin down gracefully when a SIGINT or CTRL_BREAK signal is received. Related: - pulumi/pulumi#13809 - pulumi/pulumi-yaml#501 Refs pulumi/pulumi#9780
Configures the language plugin binary to shut down the plugin RPC server
when SIGINT is received.
This will help the binary exit cleanly when it's time to shut down.
This functionality was added in pulumi/pulumi#13795.
pulumi/pulumi#13809 contains a similar change for Go, Python, and Node.