Validate that resource import ids are not outputs #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas11
added
the
impact/no-changelog-required
thomas11
force-pushed
the
tkappler/import-output
branch
from
708e73a
to
07df31d
Compare
iwahbe
reviewed
Aug 6, 2024
Comment on lines
+1144
to
+1155
| importValue, ok := e.evaluateExpr(v.Options.Import) | ||
| if ok { | ||
| if !hasOutputs(importValue) { | ||
| opts = append(opts, pulumi.Import(pulumi.ID(v.Options.Import.Value))) | ||
| } else { | ||
| e.error(v.Options.Import, "import must be not be an output") | ||
| overallOk = false | ||
| } | ||
| } else { | ||
| e.error(v.Options.Import, "couldn't evaluate the 'import' resource option") | ||
| overallOk = false | ||
| } |
There was a problem hiding this comment.
This check should be done statically. This should not happen during runtime.
Given the TODO in the PR, this code should be unreachable.
There was a problem hiding this comment.
That's true but I don't think the type checker today distinguishes between prompt/plain values and outputs. Does it?
There was a problem hiding this comment.
No. It would need to be a different pass then the type checker.
|
Closing this PR as the approach isn't correct. Tracked by #614 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A program that uses the resource import option with an
Outputas the import id:currently fails like this:
error: failed to discover plugin requirements: Pulumi.yaml:15,15-22: import must be a string.This error message is somewhat misleading, although correct in a narrow sense (outputs are not strings).This PR adds a check to detect that case and fail with a better message.
TODO: The added test does not work as intended so far: it doesn't even get to the new code in
registerResourcebut fails earlier inLoadYAMLBytes, with the previous "import must be a string" error.