Parse the items property on config type declarations #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgummerer
reviewed
Aug 21, 2024
pkg/pulumiyaml/ast/template.go
Outdated
| declNode | ||
|
|
||
| Type *StringExpr | ||
| } |
There was a problem hiding this comment.
Do we also need to include values here/is that even supported?
There was a problem hiding this comment.
Ah good spotting! I think this can be arbitrarily nested, we can use ConfigParamDecl recursively here, updated the PR!
When parsing a template, parse the `items` property on configuration type declarations. Fixes #606
justinvp
approved these changes
Aug 23, 2024
tgummerer
approved these changes
Aug 26, 2024
|
This PR has been shipped in release v1.10.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing a template, parse the
itemsproperty on configuration type declarations to avoid a diagnostic for an unknown field coming from the reflection code. The config section is parsed as part of the template, but not actually used, the config validation is performed by the engine instead.Fixes #606