Fix topological sort to take into account defaultProvider. #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpollack23
force-pushed
the
brandonpollack23/f91181f4
branch
3 times, most recently
from
485f11b
to
c507f97
Compare
|
Bug: #604 |
Frassle
reviewed
Sep 24, 2024
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly.
Bug: #643
Remote-Ref: brandonpollack23/e8219876
This was referenced Sep 25, 2024
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly.
Bug: #643
Remote-Ref: brandonpollack23/e8219876
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly.
Bug: #643
Remote-Ref: brandonpollack23/e8219876
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly.
Bug: #643
Remote-Ref: brandonpollack23/e8219876
brandonpollack23
force-pushed
the
brandonpollack23/f91181f4
branch
from
c507f97
to
07e168b
Compare
brandonpollack23
changed the base branch from
main
to
brandonpollack23/30597e61
brandonpollack23
force-pushed
the
brandonpollack23/30597e61
branch
from
22d9246
to
e88e9f8
Compare
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly.
Bug: #643
Remote-Ref: brandonpollack23/e8219876
brandonpollack23
force-pushed
the
brandonpollack23/30597e61
branch
from
e88e9f8
to
a3fbd49
Compare
brandonpollack23
force-pushed
the
brandonpollack23/f91181f4
branch
2 times, most recently
from
f8ba240
to
e882e43
Compare
brandonpollack23
force-pushed
the
brandonpollack23/30597e61
branch
from
a3fbd49
to
a3ccac9
Compare
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly.
Bug: #643
Remote-Ref: brandonpollack23/e8219876
brandonpollack23
force-pushed
the
brandonpollack23/f91181f4
branch
from
e882e43
to
a726ca1
Compare
brandonpollack23
force-pushed
the
brandonpollack23/30597e61
branch
from
a3ccac9
to
6cfae6e
Compare
brandonpollack23
force-pushed
the
brandonpollack23/f91181f4
branch
from
a726ca1
to
7abd4bf
Compare
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly.
Bug: #643
Remote-Ref: brandonpollack23/e8219876
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly.
Bug: #643
Remote-Ref: brandonpollack23/e8219876
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly.
Bug: #643
Remote-Ref: brandonpollack23/e8219876
brandonpollack23
added a commit
that referenced
this pull request
Sep 27, 2024
Also added a test to test topological sort works correctly.
Bug: #643
Remote-Ref: brandonpollack23/e8219876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The topological sort will not sort default providers first as is, so
this adds in a check to detect it and not allow implicit providers to be
complete until the default provider is declared.