-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix topological sort to take into account defaultProvider. #643
Merged
brandonpollack23
merged 0 commits into
brandonpollack23/30597e61
from
brandonpollack23/f91181f4
Sep 25, 2024
Merged
Fix topological sort to take into account defaultProvider. #643
brandonpollack23
merged 0 commits into
brandonpollack23/30597e61
from
brandonpollack23/f91181f4
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpollack23
force-pushed
the
brandonpollack23/f91181f4
branch
3 times, most recently
from
September 24, 2024 06:33
485f11b
to
c507f97
Compare
Bug: #604 |
Frassle
reviewed
Sep 24, 2024
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly. Bug: #643 Remote-Ref: brandonpollack23/e8219876
This was referenced Sep 25, 2024
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly. Bug: #643 Remote-Ref: brandonpollack23/e8219876
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly. Bug: #643 Remote-Ref: brandonpollack23/e8219876
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly. Bug: #643 Remote-Ref: brandonpollack23/e8219876
brandonpollack23
force-pushed
the
brandonpollack23/f91181f4
branch
from
September 25, 2024 05:47
c507f97
to
07e168b
Compare
brandonpollack23
changed the base branch from
main
to
brandonpollack23/30597e61
September 25, 2024 05:47
brandonpollack23
force-pushed
the
brandonpollack23/30597e61
branch
from
September 25, 2024 05:50
22d9246
to
e88e9f8
Compare
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly. Bug: #643 Remote-Ref: brandonpollack23/e8219876
brandonpollack23
force-pushed
the
brandonpollack23/30597e61
branch
from
September 25, 2024 06:00
e88e9f8
to
a3fbd49
Compare
brandonpollack23
force-pushed
the
brandonpollack23/f91181f4
branch
2 times, most recently
from
September 25, 2024 06:05
f8ba240
to
e882e43
Compare
brandonpollack23
force-pushed
the
brandonpollack23/30597e61
branch
from
September 25, 2024 06:05
a3fbd49
to
a3ccac9
Compare
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly. Bug: #643 Remote-Ref: brandonpollack23/e8219876
brandonpollack23
force-pushed
the
brandonpollack23/f91181f4
branch
from
September 25, 2024 06:12
e882e43
to
a726ca1
Compare
brandonpollack23
force-pushed
the
brandonpollack23/30597e61
branch
from
September 25, 2024 06:22
a3ccac9
to
6cfae6e
Compare
brandonpollack23
force-pushed
the
brandonpollack23/f91181f4
branch
from
September 25, 2024 06:22
a726ca1
to
7abd4bf
Compare
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly. Bug: #643 Remote-Ref: brandonpollack23/e8219876
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly. Bug: #643 Remote-Ref: brandonpollack23/e8219876
brandonpollack23
added a commit
that referenced
this pull request
Sep 25, 2024
Also added a test to test topological sort works correctly. Bug: #643 Remote-Ref: brandonpollack23/e8219876
brandonpollack23
added a commit
that referenced
this pull request
Sep 27, 2024
Also added a test to test topological sort works correctly. Bug: #643 Remote-Ref: brandonpollack23/e8219876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The topological sort will not sort default providers first as is, so
this adds in a check to detect it and not allow implicit providers to be
complete until the default provider is declared.