Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go version in github workflows #651

Merged
merged 1 commit into from
Sep 27, 2024
Merged

update go version in github workflows #651

merged 1 commit into from
Sep 27, 2024

Conversation

brandonpollack23
Copy link
Contributor

@brandonpollack23 brandonpollack23 commented Sep 25, 2024 •
edited
Loading

No description provided.

@brandonpollack23 brandonpollack23 requested a review from a team as a code owner September 25, 2024 06:35
tgummerer
tgummerer approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@tgummerer tgummerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a reference to Go 1.21.x in stage-publish.yml. Did we not upgrade that intentionally? Probably deserves a callout in the PR description if so.

Remote-Ref: brandonpollack23/30597e61

Out of curiosity, what's this?

Frassle
Frassle previously requested changes Sep 25, 2024
View reviewed changes
pkg/pulumiyaml/run.go Show resolved Hide resolved
pkg/pulumiyaml/codegen/gen_program_test.go Outdated Show resolved Hide resolved
@brandonpollack23
Copy link
Contributor Author

There's also a reference to Go 1.21.x in stage-publish.yml. Did we not upgrade that intentionally? Probably deserves a callout in the PR description if so.

Remote-Ref: brandonpollack23/30597e61

Out of curiosity, what's this?

a local tool I use to push stacks of changes as separate PRs adds that

@brandonpollack23
Copy link
Contributor Author

There's also a reference to Go 1.21.x in stage-publish.yml. Did we not upgrade that intentionally? Probably deserves a callout in the PR description if so.

Remote-Ref: brandonpollack23/30597e61

Out of curiosity, what's this?

I don't see stage publish in the repo anywhere....am I blind?

@tgummerer
Copy link
Contributor

I don't see stage publish in the repo anywhere....am I blind?

No I am just outdated. I had an older checkout lying around, but that script is gone since then. Never mind me.

tgummerer
tgummerer reviewed Sep 25, 2024
View reviewed changes
.changes/unreleased/Improvements-647.yaml Outdated Show resolved Hide resolved
pkg/pulumiyaml/codegen/gen_program_test.go Outdated Show resolved Hide resolved
pkg/pulumiyaml/run.go Show resolved Hide resolved
iwahbe
iwahbe previously requested changes Sep 25, 2024
View reviewed changes
pkg/pulumiyaml/codegen/gen_program_test.go Outdated Show resolved Hide resolved
pkg/pulumiyaml/codegen/gen_program_test.go Outdated Show resolved Hide resolved
@tgummerer tgummerer dismissed stale reviews from iwahbe and Frassle September 26, 2024 10:29

This has been sufficiently addressed.

@brandonpollack23 brandonpollack23 merged commit 5e605a7 into main Sep 27, 2024
6 checks passed
@brandonpollack23 brandonpollack23 deleted the bpollack/update_go_version branch September 27, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgummerer tgummerer tgummerer approved these changes

@Frassle Frassle Frassle left review comments

@iwahbe iwahbe iwahbe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandonpollack23 @tgummerer @Frassle @iwahbe