Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Native support for Poetry for new projects #15937

Closed
19 of 21 tasks
justinvp opened this issue Apr 15, 2024 · 0 comments
Closed
19 of 21 tasks

[Epic] Native support for Poetry for new projects #15937

justinvp opened this issue Apr 15, 2024 · 0 comments
Assignees
Labels
kind/epic Large new features or investments resolution/fixed This issue was fixed

Comments

@justinvp
Copy link
Member

justinvp commented Apr 15, 2024

Add the ability to choose a package manager to use as part of pulumi new. For Python, we'd like to offer Poetry support. For Node.js, we'd like to offer a choice between npm and yarn (and possibly pnpm and other popular tools). When running pulumi new, it could prompt the user for which package manager tool to use, based on what the language host can support and finds available on $PATH

Related issues: #13833

Design (M105)

Implementation Plan

M105

M106

Potential followups

Announce

@justinvp justinvp added the kind/epic Large new features or investments label Apr 15, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 3, 2024
…ocation to a Toolchain interface (#16243)

# Description

This PR refactors the existing Python dependency installation and
command running code to use the `Toolchain` interface. This will make it
possible to swap out the default Pip based toolchain for a Poetry based
toolchain.

Fixes #16285
Ref #15937

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [x] I have formatted my code using `gofumpt`
github-merge-queue bot pushed a commit that referenced this issue Jun 6, 2024
# Description

To correctly determine which python executable we are using, we need the
ProgramInfo so we can determine which virtual environment is in use.

This PR updates the `About` rpc call to take `ProgramInfo` as argument.

Fixes #16299
Ref #15937

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [x] I have formatted my code using `gofumpt`
github-merge-queue bot pushed a commit that referenced this issue Jun 6, 2024
# Description

Implement `Toolchain` interface for Poetry.

This does not yet allow the user to select the toolchain during `pulumi
new`, but can be used with a template that has explicit poetry support
https://github.com/pulumi/templates/pull/795/files

```
pulumi new https://github.com/pulumi/templates/tree/julienp/poetry-template/aws-python-poetry 
```
Stacked on top of #16311

Fixes #16314
Ref #15937

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [x] I have formatted my code using `gofumpt`
github-merge-queue bot pushed a commit that referenced this issue Jun 6, 2024
# Description

Implement `Toolchain` interface for Poetry.

This does not yet allow the user to select the toolchain during `pulumi
new`, but can be used with a template that has explicit poetry support
https://github.com/pulumi/templates/pull/795/files

```
pulumi new https://github.com/pulumi/templates/tree/julienp/poetry-template/aws-python-poetry 
```
Stacked on top of #16311

Fixes #16314
Ref #15937

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [x] I have formatted my code using `gofumpt`
julienp added a commit to pulumi/docs that referenced this issue Jun 28, 2024
We now have native `poetry` support to manage virtual enviroments and
dependencies.

Ref: pulumi/pulumi#15937
julienp added a commit to pulumi/docs that referenced this issue Jul 1, 2024
* Add Python Poetry documentation

We now have native `poetry` support to manage virtual enviroments and
dependencies.

Ref: pulumi/pulumi#15937

Co-authored-by: Christian Nunciato <[email protected]>
@julienp julienp added the resolution/fixed This issue was fixed label Jul 3, 2024
@julienp julienp closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic Large new features or investments resolution/fixed This issue was fixed
Projects
Status: 🚀 Shipped
Development

No branches or pull requests

2 participants