Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python Poetry documentation #12158

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Conversation

julienp
Copy link
Contributor

@julienp julienp commented Jun 28, 2024

Proposed changes

We now have native poetry support to manage virtual enviroments and
dependencies.

Related issues (optional)

Ref: pulumi/pulumi#15937

We now have native `poetry` support to manage virtual enviroments and
dependencies.

Ref: pulumi/pulumi#15937
{{% choosable os macos %}}

```bash
$ poetry add ${PACKAGE_NAME}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a concrete package name to use here, are we ok with using syntax like ${PACKAGE_NAME} to indicate that this is a place holder?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, yeah, although we don't have a particular standard around this yet (and probably should). I'll poll the team and see what they think, but IMO this is good for now.

@julienp julienp marked this pull request as ready for review June 28, 2024 13:00
@julienp julienp requested a review from cnunciato June 28, 2024 13:00
@pulumi-bot
Copy link
Collaborator

@julienp julienp requested a review from interurban June 28, 2024 13:22
Copy link
Contributor

@cnunciato cnunciato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nothing need block, just a few minor suggestions for improvement.

content/docs/languages-sdks/python/_index.md Outdated Show resolved Hide resolved
content/docs/languages-sdks/python/_index.md Outdated Show resolved Hide resolved
content/docs/languages-sdks/python/_index.md Outdated Show resolved Hide resolved
{{% choosable os macos %}}

```bash
$ poetry add ${PACKAGE_NAME}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, yeah, although we don't have a particular standard around this yet (and probably should). I'll poll the team and see what they think, but IMO this is good for now.

content/docs/languages-sdks/python/_index.md Outdated Show resolved Hide resolved
layouts/shortcodes/install-python.html Outdated Show resolved Hide resolved
Co-authored-by: Christian Nunciato <[email protected]>
@pulumi-bot
Copy link
Collaborator

@julienp julienp merged commit 932234e into master Jul 1, 2024
5 checks passed
@julienp julienp deleted the julienp/python-virtual-env-poetry branch July 1, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants