Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to validate the content and layout of common resources #3919

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

cnunciato
Copy link
Contributor

@cnunciato cnunciato commented Feb 6, 2024

Adds a set of Cypress tests to validate the layout and behavior of the API docs pages of commonly used resources, and adds a GHA workflow to run these tests daily (against pulumi.com/registry) at 6 AM Pacific time. Failed runs should generate P1 issues on this repo automatically for triage by the @pulumi/docs team.

Note that many of these tests are still failing, and some tests haven't been fleshed out yet (so are currently skipped). As we work to complete the issues that roll up into #3780, all failing tests should eventually go green, and we'll fill out the details of skipped tests as the page updates land for them.

Fixes #3907.

Copy link

github-actions bot commented Feb 7, 2024

Your site preview for commit d591f9d is ready! 🎉

http://registry--origin-pr-3919-d591f9d2.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

@cnunciato cnunciato force-pushed the cnunciato/docs-page-validations branch from d591f9d to 6cd432b Compare February 9, 2024 00:13
Copy link

github-actions bot commented Feb 9, 2024

Your site preview for commit 6cd432b is ready! 🎉

http://registry--origin-pr-3919-6cd432bc.s3-website.us-west-2.amazonaws.com/registry.

@cnunciato cnunciato force-pushed the cnunciato/docs-page-validations branch from 6cd432b to c9a5eec Compare February 15, 2024 01:17
Copy link

Your site preview for commit c9a5eec is ready! 🎉

http://registry--origin-pr-3919-c9a5eece.s3-website.us-west-2.amazonaws.com/registry.

Copy link

Your site preview for commit 98a1c0c is ready! 🎉

http://registry--origin-pr-3919-98a1c0c0.s3-website.us-west-2.amazonaws.com/registry.

@cnunciato cnunciato force-pushed the cnunciato/docs-page-validations branch from 98a1c0c to ef588ba Compare February 15, 2024 22:17
@cnunciato cnunciato force-pushed the cnunciato/docs-page-validations branch from ef588ba to 40e6ed4 Compare February 15, 2024 22:31
@cnunciato cnunciato marked this pull request as ready for review February 15, 2024 22:38
@cnunciato cnunciato force-pushed the cnunciato/docs-page-validations branch from 40e6ed4 to 5a3fedb Compare February 15, 2024 22:40
@cnunciato cnunciato force-pushed the cnunciato/docs-page-validations branch from 5a3fedb to 745a052 Compare February 15, 2024 22:41
@cnunciato cnunciato force-pushed the cnunciato/docs-page-validations branch from 745a052 to 09af92a Compare February 15, 2024 22:41
@cnunciato cnunciato force-pushed the cnunciato/docs-page-validations branch from 09af92a to 7b7ca2f Compare February 15, 2024 22:43
@cnunciato cnunciato requested review from sean1588 and a team February 15, 2024 22:45
Copy link

Your site preview for commit ef588ba is ready! 🎉

http://registry--origin-pr-3919-ef588baa.s3-website.us-west-2.amazonaws.com/registry.

@cnunciato cnunciato force-pushed the cnunciato/docs-page-validations branch from 7b7ca2f to 7d2da77 Compare February 15, 2024 22:50
@cnunciato cnunciato force-pushed the cnunciato/docs-page-validations branch from 7d2da77 to 5436826 Compare February 15, 2024 22:53
Copy link

Your site preview for commit 40e6ed4 is ready! 🎉

http://registry--origin-pr-3919-40e6ed44.s3-website.us-west-2.amazonaws.com/registry.

Copy link

Your site preview for commit 7b7ca2f is ready! 🎉

http://registry--origin-pr-3919-7b7ca2fa.s3-website.us-west-2.amazonaws.com/registry.

Copy link

Your site preview for commit 5436826 is ready! 🎉

http://registry--origin-pr-3919-54368269.s3-website.us-west-2.amazonaws.com/registry.

Copy link
Member

@sean1588 sean1588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cnunciato !! 🚀

@cnunciato cnunciato merged commit 9273782 into master Feb 16, 2024
3 checks passed
@cnunciato cnunciato deleted the cnunciato/docs-page-validations branch February 16, 2024 06:08
Copy link

Site previews for this pull request have been removed. ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add end-to-end tests to validate page structure for common resources
2 participants