feat: add pulumiverse/pulumi-fortios provider

[tmeckel]

Description

Add pulumiverse/pulumi-fortios to community-packages/package-list.json

Adding a new package?

If this pull request adds a new package:

• The package's schema URL is correct.
• The package metadata file, if present, contains:
  • a supported category (one of Cloud, Infrastructure, Network, Database, Monitoring, or Utility).
  • a description that explains what the package does.
  • a valid logo URL that points to a PNG whose dimensions conform to the others in this repo (e.g., 100x100).
  • a version number prefixed with v that corresponds with a valid GitHub release.
• The package repo contains an Overview doc (/docs/_index.md) that includes:
  • a brief explanation of what the package is and what it does.
  • at least one representative example in all supported languages.
  • a front-matter property for the layout set to package.
• The package repo contains an Installation and Configuration doc (/docs/installation-configuration.md) that includes:
  • links to SDKs in all supported languages.
  • a copyable command for installing the resource plugin if necessary.
  • an example of configuring the provider with pulumi config set.
  • an example of configuring the provider with environment variables.
• A CODEOWNER has reviewed the PR.
• A member of the @pulumi/docs team has reviewed all documentation.

[ringods]

@tmeckel I reviewed the provider. Can you have a look at the two items I didn't check:

• at least one representative code example in docs/_index.md. Can you add one?
• a copyable command for installing the resource plugin: the command is there but not complete. It is missing the --server to point to Pulumiverse (aka the PluginDownloadURL). See example here: https://github.com/pulumiverse/pulumi-scaleway/blob/main/docs/installation-configuration.md?plain=1#L16-L24

[tmeckel]

@ringods can you please have a look at the PR in the provider repo (pulumiverse/pulumi-fortios#7), if the changes to the documentation reflect your expectations.

[ringods]

@tmeckel can you rebase your PR? Due to other merges, there are conflicts now on this package list file.

[tmeckel]

@tmeckel can you rebase your PR? Due to other merges, there are conflicts now on this package list file.

@ringods done 😄

[cnunciato]

@tmeckel When I attempt to build the docs, I get an error:

panic: fatal: An assertion has failed: duplicate file: router/bgp/_index.md

Any ideas as to why? Here's where the panic occurs: https://github.com/pulumi/pulumi/blob/e86db2e79667b5cc674a94e7165437937873b220/pkg/codegen/utilities.go#L180

[tmeckel]

@tmeckel When I attempt to build the docs, I get an error:

panic: fatal: An assertion has failed: duplicate file: router/bgp/_index.md

Any ideas as to why? Here's where the panic occurs: https://github.com/pulumi/pulumi/blob/e86db2e79667b5cc674a94e7165437937873b220/pkg/codegen/utilities.go#L180

@cnunciato The root cause of this panic has been fixed with pulumi/pulumi#15035. I think you're using registrygen but registrygen is, compared to resourcedocsgen, on a pretty dated version of the Pulumi SDK, which does not contain the fix from the mentioned PR.

Just checked that resourcedocsgen isn't in the pulumi/docs repo anymore. So basically I don't really know what tools you guys are using to create the docs. So please simply ensure the tool you used has been compiled with the PR mentioned.

cc @t0yv0

[cnunciato]

@tmeckel Ah, right you are, thanks! I've updated. (And yes we pulled resourcedocsgen out of pulumi/docs -- it's now in pulumi/registry.)

[cnunciato]

@tmeckel It looks like the docs still contain some HCL. Can you run through these and make sure they're all correct?

[cnunciato]

Sorry, clicked the Approve option by mistake. (See my previous comment.)

[tmeckel]

Sorry, clicked the Approve option by mistake. (See my previous comment.)
@cnunciato Too bad 😁

Anyways ... I'll update the docs and remove (translate) or remove the HCL code you mentioned in #4184 (review)

[tmeckel]

@cnunciato

Before I create a new release of the Fortios provider, can you have a look at the PR in the provider repo pulumiverse/pulumi-fortios#8 if everything has been corrected.

[t0yv0]

LMK if I'm needed here. Happy to jump on a call.

[cnunciato]

@tmeckel I'm still seeing issues -- left you some comments on the PR. Here's what I see when I render these out:

[tmeckel]

@cnunciato It is no excuse not to work carefully, but the fact that you have to squeeze the documentation into two files with the community providers makes it easy to lose track in huge files.

We already had a discussion about this
#3159 including a PR from my side pulumi/registrygen#19

unfortunately we did not come to a conclusion.

So could you please have another look at the PR in the Fortios provider repo. I really hope that I now fixed all open issues.

[cnunciato]

Thanks for rolling with the revisions, @tmeckel!

[tmeckel]

@cnunciato created a new PR containing the fixes to the docs