Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Tutorials tab #5130

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Add the Tutorials tab #5130

merged 2 commits into from
Aug 9, 2024

Conversation

cnunciato
Copy link
Contributor

Fixes #5129.

@@ -1,25 +1,17 @@
<div class="docs-type-nav-search">
<div class="docs-type-nav">
{{ $mode := .Scratch.Get "mode" }}
Copy link
Contributor Author

@cnunciato cnunciato Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to remove this check because there's no longer a "docs" (or anything other than "registry") section in this repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah should be fine, seems to be left over from when everything was together.

@cnunciato cnunciato requested review from sean1588 and a team August 8, 2024 21:31
Copy link

github-actions bot commented Aug 8, 2024

Your site preview for commit 0c46684 is ready! 🎉

http://registry--origin-pr-5130-0c46684c.s3-website.us-west-2.amazonaws.com/registry.

Copy link
Member

@sean1588 sean1588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the previews won't show the svg since it is over in the docs repo, but the ref does resolve on the site, pulumi.com/icons/graduation-cap.svg.

Screen Shot 2024-08-08 at 4 30 59 PM

Copy link

github-actions bot commented Aug 9, 2024

Your site preview for commit e387804 is ready! 🎉

http://registry--origin-pr-5130-e3878041.s3-website.us-west-2.amazonaws.com/registry.

@cnunciato cnunciato merged commit 0e31af9 into master Aug 9, 2024
3 checks passed
@cnunciato cnunciato deleted the cnunciato/tutorials-tab branch August 9, 2024 00:42
Copy link

github-actions bot commented Aug 9, 2024

Site previews for this pull request have been removed. ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the Tutorials tab
2 participants