-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(GH-3286) Add file::delete()
function
#3287
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# frozen_string_literal: true | ||
|
||
# Delete a file on localhost using ruby's `File.delete`. This will only delete | ||
# files on the machine you run Bolt on. | ||
Puppet::Functions.create_function(:'file::delete') do | ||
# @param filename Absolute path. | ||
# @example Delete a file from disk | ||
# file::delete('C:/Users/me/report') | ||
dispatch :delete do | ||
required_param 'String[1]', :filename | ||
return_type 'Undef' | ||
end | ||
|
||
def delete(filename) | ||
# Send Analytics Report | ||
Puppet.lookup(:bolt_executor) {}&.report_function_call(self.class.name) | ||
|
||
File.delete(filename) | ||
nil | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'spec_helper' | ||
require 'tempfile' | ||
|
||
describe 'file::delete' do | ||
it { | ||
Dir.mktmpdir do |dir| | ||
file = File.join(dir, 'file_delete') | ||
File.write(file, 'file_delete_contents') | ||
is_expected.to run.with_params(file) | ||
expect(File.exist?(file)).to eq(false) | ||
end | ||
} | ||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why
nil
here, do you always want to returnnil
and not the result ofdelete()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was copied from
file::write()
actually.. In our casedelete()
will always return 1 (number of filenames passed as the arguments). Not sure how useful it is.