Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve add_facts performance #3292

Merged
merged 1 commit into from
Apr 16, 2024

Commits on Apr 3, 2024

  1. Improve add_facts performance

    When making multiple add_facts calls to add facts to an already
    present and large set of target facts performance declines
    as more are added due to the initialization and copying of
    the large hashes each time.
    
    This change merges the added facts in place to the existing
    facts, which provides a slight performance improvement.
    
    !feature
    
    * **Minor add_facts optimization**
    
      Deep merge new facts into existing target fact hash, instead
      of creating and copying a new hash each time.
    seanmil committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    efbca69 View commit details
    Browse the repository at this point in the history