Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure bash shell executions close file descriptors #3328

Merged
merged 1 commit into from
Jun 26, 2024

Commits on Jun 26, 2024

  1. Ensure bash shell executions close file descriptors

    Currently Bolt::Shell::Bash will leaves open file
    descriptors at the conclusion of execute(). The
    file descriptions do fall out of scope at the conclusion
    of the execute() method and the Ruby GC eventually closes
    them. However, on a very busy Bolt invocation with lots of
    short-lived Tasks or a number of Tasks running in parallel
    (e.g. via background()) the number of open FDs before
    garbage collection can get moderately high, hitting problems
    on systems with low file descriptor limits.
    
    !bug
    
    * **Explicitly close Bolt::Shell::Bash file descriptors**
    
      Ensure file descriptors in Bolt::Shell::Bash are explicitly
      closed, helping to alleviate the chance of hitting file
      descriptor limits on systems with low defaults (e.g. Mac OS).
    seanmil committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    4005f73 View commit details
    Browse the repository at this point in the history