(maint) Fix component CI by pinning back yard #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/puppetlabs/puppet-strings/pull/401/files for similar approach.
donoghuc
commented
Sep 20, 2024
| @@ -76,6 +77,7 @@ | |||
| on(bolt, 'gem install public_suffix -v 5.1.1 --no-document') | |||
| on(bolt, 'gem install CFPropertyList -v 3.0.6 --no-document') | |||
| on(bolt, 'gem install fast_gettext -v 2.4.0') | |||
| on(bolt, 'gem install puppet-strings -v 0.9.36 --no-document') | |||
There was a problem hiding this comment.
Oops, copy paste bug
smortex
added a commit
to smortex/bolt
that referenced
this pull request
Oct 31, 2024
Monkey patching libraries is a bad idea. Latest version of yard changed some internal details, which broke bolt. A workaround was proposed in puppetlabs#3349 but the root cause was not addressed. Detect if the version of YARD we are using provide the `YARD::Logger::Severity` class (part of the new interal API) and if so use its constants to set the log level, otherwise fallback to the previous way of setting the log level using a Symbol. While here, revert the workaround that was committed in puppetlabs#3349 and puppetlabs#3350.
smortex
added a commit
to smortex/bolt
that referenced
this pull request
Oct 31, 2024
Monkey patching libraries is a bad idea. Latest version of yard changed some internal details, which broke bolt. A workaround was proposed in puppetlabs#3349 but the root cause was not addressed. Detect if the version of YARD we are using provide the `YARD::Logger::Severity` class (part of the new interal API) and if so use its constants to set the log level, otherwise fallback to the previous way of setting the log level using a Symbol. While here, revert the workaround that was committed in puppetlabs#3349 and puppetlabs#3350.
smortex
added a commit
to smortex/bolt
that referenced
this pull request
Oct 31, 2024
Monkey patching libraries is a bad idea. Latest version of yard changed some internal details, which broke bolt. A workaround was proposed in puppetlabs#3349 but the root cause was not addressed. Detect if the version of YARD we are using provide the `YARD::Logger::Severity` class (part of the new interal API) and if so use its constants to set the log level, otherwise fallback to the previous way of setting the log level using a Symbol. While here, revert the workaround that was committed in puppetlabs#3349 and puppetlabs#3350. !no-release-note
smortex
added a commit
to smortex/bolt
that referenced
this pull request
Oct 31, 2024
Monkey patching libraries is a bad idea. Latest version of yard changed some internal details, which broke bolt. A workaround was proposed in puppetlabs#3349 but the root cause was not addressed. Detect if the version of YARD we are using provide the `YARD::Logger::Severity` class (part of the new interal API) and if so use its constants to set the log level, otherwise fallback to the previous way of setting the log level using a Symbol. While here, revert the workaround that was committed in puppetlabs#3349 and puppetlabs#3350. !no-release-note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/puppetlabs/puppet-strings/pull/401/files for similar approach.