(CAT-1488) - Fix windows acceptance tests #1281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavindidrichsen
added
the
maintenance
gavindidrichsen
force-pushed
the
cat_1488_fix_windows_accep_tests
branch
from
8f0aa91
to
cec5a47
Compare
gavindidrichsen
force-pushed
the
cat_1488_fix_windows_accep_tests
branch
2 times, most recently
from
ddffa6c
to
3168827
Compare
commit ddffa6c Author: Code Manager <code_manager@agent-694ff4-0> Date: Tue Oct 10 13:11:34 2023 +0000 Fix undefined local 'path' Fixed failing tests after refactoring around(:all) into before/after(:all): ``Failure/Error: FileUtils.rm_f(path) NameError: undefined local variable or method `path'...`` commit 10821c5 Author: Gavin Didrichsen <[email protected]> Date: Thu Oct 5 21:00:17 2023 +0100 (CAT-1488) - Fix some rubocop warnings Signed-off-by: Gavin Didrichsen <[email protected]> commit 831c41d Author: Gavin Didrichsen <[email protected]> Date: Thu Oct 5 20:34:03 2023 +0100 (CAT-1488) - Split around(:all) into before/after(:all) This fixes duplicate code warnings occurring during the acceptance tests. Signed-off-by: Gavin Didrichsen <[email protected]> commit d2cec4b Author: Gavin Didrichsen <[email protected]> Date: Thu Oct 5 20:32:51 2023 +0100 (CAT-1488) - Refactor duplicated shared examples and context This fixes duplicate definition warnings in the acceptance tests. Signed-off-by: Gavin Didrichsen <[email protected]>
gavindidrichsen
force-pushed
the
cat_1488_fix_windows_accep_tests
branch
from
3168827
to
ee96de5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist