Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PA-6383) consistently apply PIE compiler flags #831

Closed
wants to merge 8 commits into from

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Apr 18, 2024

Had a rough version of this patch stashed away. Intends to addresses #819

  • agent-runtime-7.x
  • agent-runtime-main
  • bolt-runtime
  • pdk-runtime
  • client-tools-runtime-2021.7.x
  • client-tools-runtime-main
  • pe-bolt-server-runtime-2021.7.x
  • pe-bolt-server-runtime-main
  • pe-installer-runtime-2021.7.x
  • pe-installer-runtime-main

@h0tw1r3 h0tw1r3 added the maintenance Maintenance chores are typically excluded from changelogs label Apr 18, 2024
@h0tw1r3 h0tw1r3 changed the title Yummy pie (PA-6383) consistently apply PIE compiler flags Apr 18, 2024
@h0tw1r3 h0tw1r3 force-pushed the yummy-pie branch 5 times, most recently from c5df90a to f778819 Compare April 24, 2024 14:19
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented Apr 24, 2024

Confirmed flags by extracting the built runtime, then using readelf on a binary or library:
Run readelf -p .GCC.command.line opt/puppetlabs/puppet/bin/openssl | grep -- no-plt

Ubuntu 18.04:
no output

Ubuntu 20.04:

  [     0]  GNU C17 11.4.0 -mlittle-endian -mabi=lp64 -O2 -fstack-protector-strong -fno-plt -fasynchronous-unwind-tables -fstack-protector-strong -fstack-clash-protection
  [    9f]  GNU C17 11.4.0 -mlittle-endian -mabi=lp64 -O2 -fPIC -fstack-protector-strong -fno-plt -fasynchronous-unwind-tables -fstack-protector-strong -fstack-clash-protection

@h0tw1r3 h0tw1r3 force-pushed the yummy-pie branch 2 times, most recently from fb908b9 to 36f15ad Compare April 26, 2024 05:23
@joshcooper
Copy link
Contributor

Superseded by #892

@joshcooper joshcooper closed this Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance chores are typically excluded from changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants