Allow --icc=false option for docker daemon #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to be possible in version 9.1.0 and older, but got lost in translation from .erb to .epp templates. Fixes puppetlabs#989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be possible in version 9.1.0 and older, but got lost in translation from .erb to .epp templates.
Fixes #989
Summary
Changes 5 templates to use unless instead of if for the --icc parameter
Additional Context
If a user wants to specify the --icc parameter, they always will want to use --icc=false, as the default is true.
By using
if $iccin the template, it is impossible to set -icc=false.Related Issues (if any)
See issue #989
Checklist
puppet apply)