Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

params.pp: cleanup service provider logic #1593

Merged
merged 2 commits into from
Dec 5, 2023
Merged

params.pp: cleanup service provider logic #1593

merged 2 commits into from
Dec 5, 2023
+11 −24

Conversation

bastelfreak
Copy link
Collaborator

@bastelfreak bastelfreak commented Aug 16, 2023 •
edited
Loading

the service provider will figure it out on its own. We don't need to duplicate the logic from the providers into puppet code.

@bastelfreak bastelfreak requested review from alexjfisher and a team as code owners August 16, 2023 08:09
@bastelfreak bastelfreak changed the title params.pp: Drop unused $server_service_provider variable params.pp: cleanup service provider logic Aug 16, 2023
kajinamit
kajinamit approved these changes Nov 28, 2023
View reviewed changes
Copy link

@kajinamit kajinamit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes very clear sense

@bastelfreak
params.pp: cleanup service provider logic
a3a200f 
the service provider will figure it out on its own. We don't need to
duplicate the logic from the providers into puppet code.
@Ramesh7 Ramesh7 merged commit e69e11a into puppetlabs:main Dec 5, 2023
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon approved these changes

@Ramesh7 Ramesh7 Ramesh7 approved these changes

@kajinamit kajinamit kajinamit approved these changes

@alexjfisher alexjfisher Awaiting requested review from alexjfisher alexjfisher is a code owner

Assignees
No one assigned
Labels
community maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bastelfreak @kenyon @Ramesh7 @kajinamit @ia-content