Add support for ALL grant on mysql >= 8.0.33 #1618
Conversation
alaunay
requested review from
alexjfisher,
bastelfreak and
a team
as code owners
|
|
|
So much looking forward to this! (FWIW, this is also causing issues when performing long-running schema changes.) @Ramesh7, maybe if you find some time, would you have a look at this please? Thanks :) |
|
Any progress in reviewing that PR? |
|
ping @puppetlabs |
|
Would be good to have an eta for this. Although can easily ignore it's a pain when developing and seeing constant changes |
|
Maybe @alexjfisher or @bastelfreak ? Been a few months 😅 |
|
@ianc769 can you please rebase against main to get rid of the merge commit? |
| # rubocop:disable Layout/LineLength | ||
| if (newer_than('mysql' => '8.0.0') && (sorted_privileges == mysql_v8_privileges || sorted_privileges == mysqlcluster_v8_privileges)) || sorted_privileges == mysql_pre_v8_privileges_one || sorted_privileges == mysql_pre_v8_privileges_two | ||
| if (newer_than('mysql' => '8.0.0') && (sorted_privileges == mysql_v8_privileges || sorted_privileges == mysqlcluster_v8_privileges)) || sorted_privileges == mysql_pre_v8_privileges_one || sorted_privileges == mysql_pre_v8_privileges_two || sorted_privileges == mysql_pre_v8_privileges_three |
There was a problem hiding this comment.
can we somehow have an acceptance tests for this?
fix mistakes fix spec for the changed query
Value of the facter :macaddress was nil, causing tests to have two failures (contexts "igalic's laptop" and "node with lo only"). Update the facter initialization allows to pass the tests successfully.
* When using multiple excluded databases, the list of databases is filtered using `grep -v`. i.e. `grep -v '^\(information_schema|performance_schema\)$` * When using Basic vs Extended Regular Expressions, the characters `(` and `|` lose their special meaning, the backslashed versions have to be used. For the group (`()`) the escaping has been done, however the alternation is unescaped. Leading to: * All the excluded databases will be backed up. * In case a database is not backuppable (which is why it had been excluded), this leads to the cleanup not being run at all, as it depends on the backup having been successful. This MR aims to fix this issue, by revising the regular expression and specifying that behaviour in the respective class spec.
|
I probably borked the branch, here's the patch, it'll be easier. (renamed it to .txt, it didn't like a .patch...) |
Summary
This patch add ALL grant support for mysql >= 8.0.33, due tot the recent addition of the new TELEMETRY_LOG_ADMIN, see:
https://docs.oracle.com/cd/E17952_01/mysql-8.0-relnotes-en/news-8-0-33.html#mysqld-8-0-33-feature
Additional Context
Add any additional context about the problem here.
Puppet changes grant at each run:
Add the new TELEMETRY_LOG_ADMIN, according to previous code.
Related Issues (if any)
Issue #1474 #1502 #1503
Checklist
puppet apply)