Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PE-36457) use attribute in csr for auto-reneal indication #2762

Merged

Conversation

jonathannewman
Copy link
Contributor

This changes the mechanism used to determine if an agent should have the shorter "auto-renewal" ttl for Certificate Signing Requests, or if it should use the default ca-ttl.

The agent will include an attribute that indicates with a "true" value that it supports auto-renewal. If the attribute is missing, or is a "false" value, the indication is that it does not support auto-renewal.

Tests are updated as needed to demonstrate the new behaviors.

The code related to creating, interrogating and deleting the indicator file have been removed.

This changes the mechanism used to determine if an agent should have
the shorter "auto-renewal" ttl for Certificate Signing Requests, or
if it should use the default ca-ttl.

The agent will include an attribute that indicates with a "true" value
that it supports auto-renewal. If the attribute is missing, or is a "false"
value, the indication is that it does not support auto-renewal.

Tests are updated as needed to demonstrate the new behaviors.

The code related to creating, interrogating and deleting the indicator
file have been removed.
@jonathannewman jonathannewman requested a review from a team as a code owner July 12, 2023 00:16
Copy link
Contributor

@steveax steveax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@steveax steveax merged commit b743386 into puppetlabs:main Jul 12, 2023
@jonathannewman jonathannewman deleted the PE-36457/main/use-csr-attribute branch July 12, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants