(PE-37345) Create new bulk signing endpoints #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artlawson
force-pushed
the
PE-37345
branch
14 times, most recently
from
c67a97a
to
a6f079c
Compare
artlawson
force-pushed
the
PE-37345
branch
3 times, most recently
from
b706d98
to
533ac24
Compare
artlawson
force-pushed
the
PE-37345
branch
5 times, most recently
from
c6d2c55
to
db30c07
Compare
|
This looks great. Would you mind adding a test that demonstrates the behavior when the payload doesn't comply with the schema. The tests can act as a point of documentation in this regard as well as a guarantee that we maintain consistent behavior. |
artlawson
force-pushed
the
PE-37345
branch
2 times, most recently
from
f62ae3e
to
f96d9b4
Compare
artlawson
force-pushed
the
PE-37345
branch
23 times, most recently
from
63d5529
to
5af3792
Compare
.../certificate_authority/certificate_authority_int_test/ca_true_test/master/conf/ca/ca_crl.pem
Outdated
Show resolved
Hide resolved
artlawson
force-pushed
the
PE-37345
branch
2 times, most recently
from
c0cfe90
to
cd3bcad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.