(PE-39250) Remove project APIs and configuration #2882
+25
−257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes access to file_metadata and compile options which allowed fetching data and compiling for bolt projects. This commit does not remove all project based code, it is restricted to covering enough ground to remove access to any functionality, but there may still be some internal code left over.
|
I assume this can also go: https://github.com/puppetlabs/puppetserver/pull/2882/files#diff-b0f611aa58814be93f011d5e22ed06752df5baf8fd4f2e960d882171a3fb4d13R966 ? I believe if that goes then this file can go https://github.com/puppetlabs/puppetserver/blob/main/src/clj/puppetlabs/services/master/file_serving.clj |
| [this jruby-instance compile-options boltlib-path] | ||
| (.compileAST jruby-instance compile-options boltlib-path)) | ||
| [this jruby-instance compile-options] | ||
| (.compileAST jruby-instance compile-options)) |
There was a problem hiding this comment.
It looks like this was added as part of apply work, regardless of projects. e05b75e Is that right?
There was a problem hiding this comment.
UGH, DAMNIT.
Yeah, you're correct
|
It looks like there was some spec updates made as part of 9cb17ad that still reference projects. I know this PR wasn't meant to get rid of everything, but I'm surprised the specs are passing with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes access to file_metadata and compile options which allowed fetching data and compiling for bolt projects. This commit does not remove all project based code, it is restricted to covering enough ground to remove access to any functionality, but there may still be some internal code left over.