(CAT-2061) Fix empty string nullification

[david22swan]

Reinstating reverted change by Clebam with additional fix suggested by original author.

Original PR: #292
Revert PR: #342
Reason for revert: #340
Original author: https://github.com/Clebam

Checklist

• 🟢 Spec tests.
• 🟢 Acceptance tests.
• Manually verified.

[david22swan]

@Clebam Could you confirm that this is what you had in mind for your suggested fix on the revert PR?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.08%. Comparing base (78c3f26) to head (ccd3b58).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   92.08%   92.08%           
=======================================
  Files           6        6           
  Lines         720      720           
=======================================
  Hits          663      663           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Clebam]

Hi @david22swan, Yes indeed. The purpose of this piece of code is to avoid sending a nil to a value that accepts only an Enum containing an empty string ''.

Originally my regex was a bit to wide an included Array[Enum[... (leading to the issue that lead to the revert)

The fix should properly only aim at Enum[

[jordanbreen28]

LGTM