purescript-indentation.el: improve compiler visibility into local variables #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi-Angel
changed the title
Turning on lexical-binding fixes a bunch of warnings like:
purescript-indentation.el:399:47: Warning: ‘pi’ is an obsolete variable (as of 23.3); use ‘float-pi’ instead.
these warnings are caused by Emacs not being able to determine that
`pi` is actually a local variable. By making use of lexical binding we
make Emacs to be able to see through that.
Hi-Angel
force-pushed
the
turnon-indentation-lexical-binding
branch
from
6e47731
to
c3d297c
Compare
Hi-Angel
changed the title
|
Think you could figure out why the CI is failing here as well? Happy to merge after that. Thanks! |
|
Well, it fails because latest upstream Emacs expects "lexical-binding" directive to be in every file, that's a new warning. I'll look at fixing that, but that said I don't think CI was ever passing here, because even that new error aside, it has other byte-compilation errors such as about docstring being too wide or unescaped characters usage in docstring, etc. Even the |
|
Allright, in that case I'm happy to merge. Don't worry about fixing stuff that was already erroring. |
|
@kritzcreek anyway, I went on and fixed all errors in this PR, please review 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turning on lexical-binding fixes a bunch of warnings like:
these warnings are caused by Emacs not being able to determine that
piis actually a local variable. By making use of lexical binding we make Emacs to be able to see through that.