Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont escape prop and attribute values #9

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

dont escape prop and attribute values #9

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f245c7
fix: it renders `<script async="" type="application&#x2F;javascript" …
srghma Jun 16, 2020
48fcab8
fix: error `expected false, but got true` on `<button disabled></butt…
srghma Jun 16, 2020
8d3d50b
feat: handle additional props in propNameToAttrName -> add (related t…
srghma Jul 24, 2020
8eeee70
fix: TypeError: s.replace is not a function
srghma Aug 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/Halogen/VDom/DOM/StringRenderer.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,24 @@ renderProp = case _ of
Ref _ → Nothing

renderAttr ∷ String → String → Maybe String
renderAttr name value = Just $ escape name <> "=\"" <> escape value <> "\""
renderAttr name value = Just $ escape name <> "=\"" <> value <> "\""

propNameToAttrName ∷ String → String
propNameToAttrName = case _ of
"htmlFor" → "for"
"className" → "class"
"httpEquiv" → "http-equiv"
"acceptCharset" → "accept-charset"
p → p

renderProperty ∷ String → PropValue → Maybe String
renderProperty name prop = case typeOf (unsafeToForeign prop) of
"string" → renderAttr name' $ (unsafeCoerce ∷ PropValue → String) prop
"number" → renderAttr name' $ show ((unsafeCoerce ∷ PropValue → String) prop)
"boolean" → Just $ escape name'
"number" → renderAttr name' $ show ((unsafeCoerce ∷ PropValue → Number) prop)
"boolean" →
if ((unsafeCoerce :: PropValue -> Boolean) prop)
then Just $ escape name'
else Nothing
_ → Nothing
where
name' = propNameToAttrName name
Expand Down