Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When publishing, check only the published project's dependencies, not all workspace dependencies #1314

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

fsoikin
Copy link
Collaborator

@fsoikin fsoikin commented Jan 23, 2025

Description of the change

Fixes #1307

spago publish no longer refuses to publish the root project when another project in the workspace has it as a dependency.

Checklist:

  • Added the change to the "Unreleased" section of the changelog
  • Added some example of the new feature to the README
  • Added a test for the contribution (if applicable)

@fsoikin
Copy link
Collaborator Author

fsoikin commented Jan 23, 2025

I ran into this when trying to publish https://github.com/collegevine/purescript-whine

The ./bootstrap subproject references whine-core, which prevents whine-core from being published, paradoxically complaining that whine-core is not in the registry.

I've been publishing it with a locally patched version of Spago.

Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stellar, thanks!

@f-f f-f merged commit 9cd1209 into purescript:master Jan 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot publish a project that is referenced by other projects in the workspace
2 participants