Use spago for managing the server package set, attempt 2 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natefaubion
reviewed
Apr 12, 2020
Comment on lines
+34
to
+35
| , "react" | ||
| , "react-dom" |
There was a problem hiding this comment.
Is this mainly for testing the shim stuff? Do we intend to have a process for adding additional libraries from the set. Or perhaps we should just blanket state we are not adding more libraries until we figure out a caching/purging solution for externs?
There was a problem hiding this comment.
I think I originally added these a week or two ago for testing the shim stuff, yeah. I'd like to at least add back libraries which were previously provided by other backends (#142). After that, saying we are not going to add any more libraries until we figure out a caching/purging solution (at which point we can add the whole package set) works for me.
natefaubion
approved these changes
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #148, except we keep the same set of dependencies.