perf: speculative performance improvemnt, testing HasListeners before…

… use
purview-dev · May 20, 2024 · 7d23021 · 7d23021
1 parent 3984f1b
commit 7d23021
Show file tree

Hide file tree

Showing 38 changed files with 483 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -4,7 +4,7 @@ SOLUTION_FILE = $(ROOT_FOLDER)Purview.Telemetry.SourceGenerator.sln
 TEST_PROJECT = $(ROOT_FOLDER)Purview.Telemetry.SourceGenerator.sln
 CONFIGURATION = Release
 
-PACK_VERSION = 1.0.6
+PACK_VERSION = 1.0.7
 ARTIFACT_FOLDER = p:/sync-projects/.local-nuget/
 
 # Targets

diff --git a/...blyEnableDI_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs b/...blyEnableDI_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs
@@ -41,6 +41,11 @@ static void RecordExceptionInternal(System.Diagnostics.Activity? activity, Syste
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Activity(string stringParam, int intParam, bool boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			System.Diagnostics.Activity? activityActivity = _activitySource.StartActivity(name: "Activity", kind: System.Diagnostics.ActivityKind.Internal, parentId: default, tags: default, links: default, startTime: default);
 
 			if (activityActivity != null)
@@ -58,6 +63,11 @@ public void Activity(string stringParam, int intParam, bool boolParam)
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Event(string stringParam, int intParam, bool boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			if (System.Diagnostics.Activity.Current != null)
 			{
 				System.Diagnostics.ActivityTagsCollection tagsCollectionEvent = new System.Diagnostics.ActivityTagsCollection();

diff --git a/...AndNoReturn_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs b/...AndNoReturn_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs
@@ -41,12 +41,22 @@ static void RecordExceptionInternal(System.Diagnostics.Activity? activity, Syste
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Activity()
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			System.Diagnostics.Activity? activityActivity = _activitySource.StartActivity(name: "Activity", kind: System.Diagnostics.ActivityKind.Internal, parentId: default, tags: default, links: default, startTime: default);
 		}
 
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Context(System.Diagnostics.Activity activityParameter, string? stringParam, int? intParam, bool? boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			if (activityParameter != null)
 			{
 				activityParameter.SetTag("intparam", intParam);
@@ -58,6 +68,11 @@ public void Context(System.Diagnostics.Activity activityParameter, string? strin
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void ContextWithNullableParams(System.Diagnostics.Activity? activityParameter, string? stringParam, int? intParam, bool? boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			if (activityParameter != null)
 			{
 				activityParameter.SetTag("intparam", intParam);

diff --git a/...ithActivity_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs b/...ithActivity_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs
@@ -41,12 +41,22 @@ static void RecordExceptionInternal(System.Diagnostics.Activity? activity, Syste
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Activity()
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			System.Diagnostics.Activity? activityActivity = _activitySource.StartActivity(name: "Activity", kind: System.Diagnostics.ActivityKind.Internal, parentId: default, tags: default, links: default, startTime: default);
 		}
 
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public System.Diagnostics.Activity Context(System.Diagnostics.Activity activityParameter, string? stringParam, int? intParam, bool? boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return null!;
+			}
+
 			if (activityParameter != null)
 			{
 				activityParameter.SetTag("intparam", intParam);
@@ -60,6 +70,11 @@ public System.Diagnostics.Activity Context(System.Diagnostics.Activity activityP
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public System.Diagnostics.Activity? ContextWithNullableParams(System.Diagnostics.Activity? activityParameter, string? stringParam, int? intParam, bool? boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return null;
+			}
+
 			if (activityParameter != null)
 			{
 				activityParameter.SetTag("intparam", intParam);

diff --git a/...lableParams_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs b/...lableParams_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs
@@ -41,12 +41,22 @@ static void RecordExceptionInternal(System.Diagnostics.Activity? activity, Syste
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Activity()
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			System.Diagnostics.Activity? activityActivity = _activitySource.StartActivity(name: "Activity", kind: System.Diagnostics.ActivityKind.Internal, parentId: default, tags: default, links: default, startTime: default);
 		}
 
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public System.Diagnostics.Activity Context(string? stringParam, int? intParam, bool? boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return null!;
+			}
+
 			if (System.Diagnostics.Activity.Current != null)
 			{
 				System.Diagnostics.Activity.Current.SetTag("intparam", intParam);
@@ -60,6 +70,11 @@ public System.Diagnostics.Activity Context(string? stringParam, int? intParam, b
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public System.Diagnostics.Activity? ContextWithNullableParams(string? stringParam, int? intParam, bool? boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return null;
+			}
+
 			if (System.Diagnostics.Activity.Current != null)
 			{
 				System.Diagnostics.Activity.Current.SetTag("intparam", intParam);

diff --git a/...ingActivity_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs b/...ingActivity_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs
@@ -41,12 +41,22 @@ static void RecordExceptionInternal(System.Diagnostics.Activity? activity, Syste
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Activity()
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			System.Diagnostics.Activity? activityActivity = _activitySource.StartActivity(name: "Activity", kind: System.Diagnostics.ActivityKind.Internal, parentId: default, tags: default, links: default, startTime: default);
 		}
 
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public System.Diagnostics.Activity Context(string stringParam, int intParam, bool boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return null!;
+			}
+
 			if (System.Diagnostics.Activity.Current != null)
 			{
 				System.Diagnostics.Activity.Current.SetTag("intparam", intParam);

diff --git a/...bleActivity_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs b/...bleActivity_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs
@@ -41,12 +41,22 @@ static void RecordExceptionInternal(System.Diagnostics.Activity? activity, Syste
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Activity()
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			System.Diagnostics.Activity? activityActivity = _activitySource.StartActivity(name: "Activity", kind: System.Diagnostics.ActivityKind.Internal, parentId: default, tags: default, links: default, startTime: default);
 		}
 
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public System.Diagnostics.Activity Context(string stringParam, int intParam, bool boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return null!;
+			}
+
 			if (System.Diagnostics.Activity.Current != null)
 			{
 				System.Diagnostics.Activity.Current.SetTag("intparam", intParam);
@@ -60,6 +70,11 @@ public System.Diagnostics.Activity Context(string stringParam, int intParam, boo
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public System.Diagnostics.Activity? ContextWithNullableReturnActivity(string stringParam, int intParam, bool boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return null;
+			}
+
 			if (System.Diagnostics.Activity.Current != null)
 			{
 				System.Diagnostics.Activity.Current.SetTag("intparam", intParam);

diff --git a/...cContextGen_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs b/...cContextGen_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs
@@ -41,12 +41,22 @@ static void RecordExceptionInternal(System.Diagnostics.Activity? activity, Syste
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Activity()
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			System.Diagnostics.Activity? activityActivity = _activitySource.StartActivity(name: "Activity", kind: System.Diagnostics.ActivityKind.Internal, parentId: default, tags: default, links: default, startTime: default);
 		}
 
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Context(string stringParam, int intParam, bool boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			if (System.Diagnostics.Activity.Current != null)
 			{
 				System.Diagnostics.Activity.Current.SetTag("intparam", intParam);

diff --git a/...tyParameter_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs b/...tyParameter_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs
@@ -41,12 +41,22 @@ static void RecordExceptionInternal(System.Diagnostics.Activity? activity, Syste
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Activity()
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			System.Diagnostics.Activity? activityActivity = _activitySource.StartActivity(name: "Activity", kind: System.Diagnostics.ActivityKind.Internal, parentId: default, tags: default, links: default, startTime: default);
 		}
 
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Event(System.Diagnostics.Activity activity, string stringParam, int intParam, bool boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			if (activity != null)
 			{
 				System.Diagnostics.ActivityTagsCollection tagsCollectionEvent = new System.Diagnostics.ActivityTagsCollection();

diff --git a/...tyParameter_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs b/...tyParameter_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs
@@ -41,12 +41,22 @@ static void RecordExceptionInternal(System.Diagnostics.Activity? activity, Syste
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Activity()
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			System.Diagnostics.Activity? activityActivity = _activitySource.StartActivity(name: "Activity", kind: System.Diagnostics.ActivityKind.Internal, parentId: default, tags: default, links: default, startTime: default);
 		}
 
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Event(System.Diagnostics.Activity? activity, string stringParam, int intParam, bool boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			if (activity != null)
 			{
 				System.Diagnostics.ActivityTagsCollection tagsCollectionEvent = new System.Diagnostics.ActivityTagsCollection();

diff --git a/...ctivityName_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs b/...ctivityName_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs
@@ -41,6 +41,11 @@ static void RecordExceptionInternal(System.Diagnostics.Activity? activity, Syste
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Activity(string stringParam, int intParam, bool boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			System.Diagnostics.Activity? activityActivity = _activitySource.StartActivity(name: "Activity", kind: System.Diagnostics.ActivityKind.Internal, parentId: default, tags: default, links: default, startTime: default);
 
 			if (activityActivity != null)
@@ -58,6 +63,11 @@ public void Activity(string stringParam, int intParam, bool boolParam)
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Event(string stringParam, int intParam, bool boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			if (System.Diagnostics.Activity.Current != null)
 			{
 				System.Diagnostics.ActivityTagsCollection tagsCollectionEvent = new System.Diagnostics.ActivityTagsCollection();

diff --git a/...lableParams_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs b/...lableParams_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs
@@ -41,6 +41,11 @@ static void RecordExceptionInternal(System.Diagnostics.Activity? activity, Syste
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public System.Diagnostics.Activity? Activity(string? stringParam, int? intParam, bool? boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return null;
+			}
+
 			System.Diagnostics.Activity? activityActivity = _activitySource.StartActivity(name: "Activity", kind: System.Diagnostics.ActivityKind.Internal, parentId: default, tags: default, links: default, startTime: default);
 
 			if (activityActivity != null)
@@ -60,6 +65,11 @@ static void RecordExceptionInternal(System.Diagnostics.Activity? activity, Syste
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public System.Diagnostics.Activity? ActivityWithNullableParams(string? stringParam, int? intParam, bool? boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return null;
+			}
+
 			System.Diagnostics.Activity? activityActivityWithNullableParams = _activitySource.StartActivity(name: "ActivityWithNullableParams", kind: System.Diagnostics.ActivityKind.Internal, parentId: default, tags: default, links: default, startTime: default);
 
 			if (activityActivityWithNullableParams != null)

diff --git a/...ingActivity_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs b/...ingActivity_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs
@@ -41,6 +41,11 @@ static void RecordExceptionInternal(System.Diagnostics.Activity? activity, Syste
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public System.Diagnostics.Activity Activity(string stringParam, int intParam, bool boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return null!;
+			}
+
 			System.Diagnostics.Activity? activityActivity = _activitySource.StartActivity(name: "Activity", kind: System.Diagnostics.ActivityKind.Internal, parentId: default, tags: default, links: default, startTime: default);
 
 			if (activityActivity != null)
@@ -60,6 +65,11 @@ public System.Diagnostics.Activity Activity(string stringParam, int intParam, bo
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public System.Diagnostics.Activity Event(string stringParam, int intParam, bool boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return null!;
+			}
+
 			if (System.Diagnostics.Activity.Current != null)
 			{
 				System.Diagnostics.ActivityTagsCollection tagsCollectionEvent = new System.Diagnostics.ActivityTagsCollection();

diff --git a/...bleActivity_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs b/...bleActivity_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs
@@ -41,6 +41,11 @@ static void RecordExceptionInternal(System.Diagnostics.Activity? activity, Syste
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public System.Diagnostics.Activity Activity(string stringParam, int intParam, bool boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return null!;
+			}
+
 			System.Diagnostics.Activity? activityActivity = _activitySource.StartActivity(name: "Activity", kind: System.Diagnostics.ActivityKind.Internal, parentId: default, tags: default, links: default, startTime: default);
 
 			if (activityActivity != null)
@@ -60,6 +65,11 @@ public System.Diagnostics.Activity Activity(string stringParam, int intParam, bo
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public System.Diagnostics.Activity? ActivityWithNullableReturnActivity(string stringParam, int intParam, bool boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return null;
+			}
+
 			System.Diagnostics.Activity? activityActivityWithNullableReturnActivity = _activitySource.StartActivity(name: "ActivityWithNullableReturnActivity", kind: System.Diagnostics.ActivityKind.Internal, parentId: default, tags: default, links: default, startTime: default);
 
 			if (activityActivityWithNullableReturnActivity != null)

diff --git a/...venBasicGen_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs b/...venBasicGen_GeneratesActivity.DotNet8_0#Testing.TestActivitiesCore.Activity.g.verified.cs
@@ -41,6 +41,11 @@ static void RecordExceptionInternal(System.Diagnostics.Activity? activity, Syste
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Activity(string stringParam, int intParam, bool boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			System.Diagnostics.Activity? activityActivity = _activitySource.StartActivity(name: "Activity", kind: System.Diagnostics.ActivityKind.Internal, parentId: default, tags: default, links: default, startTime: default);
 
 			if (activityActivity != null)
@@ -58,6 +63,11 @@ public void Activity(string stringParam, int intParam, bool boolParam)
 		[System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveInlining)]
 		public void Event(string stringParam, int intParam, bool boolParam)
 		{
+			if (!_activitySource.HasListeners())
+			{
+				return;
+			}
+
 			if (System.Diagnostics.Activity.Current != null)
 			{
 				System.Diagnostics.ActivityTagsCollection tagsCollectionEvent = new System.Diagnostics.ActivityTagsCollection();