Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/726/ccli improvement #737

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

njaeggi
Copy link
Contributor

@njaeggi njaeggi commented Jul 3, 2023

No description provided.

@njaeggi njaeggi mentioned this pull request Jul 3, 2023
4 tasks
@njaeggi njaeggi requested a review from MarcEgliP July 4, 2023 07:32
@njaeggi njaeggi marked this pull request as ready for review July 4, 2023 07:32
Copy link
Collaborator

@MarcEgliP MarcEgliP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

@njaeggi njaeggi requested a review from Robin481 July 4, 2023 08:09
@lkleisa lkleisa force-pushed the feature/726/ccli-improvement branch from b1ae5b9 to ef4fcf7 Compare July 12, 2023 08:26
@lkleisa
Copy link
Collaborator

lkleisa commented Jul 12, 2023

For me, the implementation didn't work with the copy buttons. I figured out, that the copy function in our clipboard service is soooo long, so I replaced our own method to copy something to clipboard with a one-liner of JavaScript, which is working on all browsers: https://developer.mozilla.org/en-US/docs/Web/API/Clipboard/writeText

@MarcEgliP MarcEgliP force-pushed the feature/726/ccli-improvement branch from 7784538 to 7fd3605 Compare July 21, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants