Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix linter issues in conf.py #2214

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix linter issues in conf.py #2214

merged 1 commit into from
Sep 17, 2024

Conversation

RDaxini
Copy link
Contributor

@RDaxini RDaxini commented Sep 17, 2024 •
edited by kandersolar
Loading

  • See comment and comment
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@RDaxini RDaxini changed the title Update conf.py fix linter issues in conf.py Sep 17, 2024
@RDaxini RDaxini marked this pull request as ready for review September 17, 2024 11:09
@kandersolar kandersolar added documentation build tools Pipelines, CI, GH actions labels Sep 17, 2024
@kandersolar kandersolar added this to the v0.11.1 milestone Sep 17, 2024
kandersolar
kandersolar approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RDaxini!

@kandersolar kandersolar merged commit 5d23f14 into pvlib:main Sep 17, 2024
29 of 32 checks passed
@RDaxini RDaxini deleted the conf.py_linter branch September 17, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kandersolar kandersolar kandersolar approved these changes

Assignees
No one assigned
Labels
build tools Pipelines, CI, GH actions documentation
Projects
None yet
Milestone
v0.11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@RDaxini @kandersolar