Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document "racking model" for temperature models #2293

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cwhanse
Copy link
Member

@cwhanse cwhanse commented Nov 11, 2024

  • Closes Missing explanation of mounting type in document #1323
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Also removes the no-longer correct default from the docstring of PVSystem

@RDaxini
Copy link
Contributor

RDaxini commented Nov 12, 2024

I think we have some overlap here with #2232, e.g. with pvlib/pvsystem.py

@cwhanse
Copy link
Member Author

cwhanse commented Nov 12, 2024

I think we have some overlap here with #2232, e.g. with pvlib/pvsystem.py

Right. I'll sort that. We should merge #2232 first then fix this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing explanation of mounting type in document
2 participants