Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readthedocs config #15

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Update readthedocs config #15

merged 1 commit into from
Jun 25, 2024

Conversation

kandersolar
Copy link
Member

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

RTD doesn't like this project's configuration file. See the warnings on this build: https://readthedocs.org/projects/solarfactors/builds/21172217/

Your builds will stop working soon!
"build.image" config key is deprecated and it will be removed soon. Read our blog post to know how to migrate to new key "build.os" and ensure your project continues building successfully.

Your builds will stop working soon!
Configuration files will soon be required by projects, and will no longer be optional. Read our blog post to create one and ensure your project continues building successfully.

This PR updates the configuration file to the current recommended state.

@kandersolar kandersolar added the documentation Improvements or additions to documentation label Oct 10, 2023
@kandersolar kandersolar added this to the 1.5.4 milestone Oct 10, 2023
@echedey-ls
Copy link

Any reason this got delayed? Porting pvlib org packages to share a common infrastructure seems like a priority in the long term.

@kandersolar kandersolar merged commit c161def into pvlib:main Jun 25, 2024
16 of 17 checks passed
@kandersolar kandersolar deleted the rtd branch June 25, 2024 12:43
@kandersolar
Copy link
Member Author

I probably just never came back to merge it after waiting for the CI build to complete. Thanks for the reminder @echedey-ls :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants