-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests directory to root level #129
Conversation
Can we start the changes on the test with the GitHub actions running the test suite? So we are sure we don't break anything here... |
Yes, we should -- I started working on that, but there's a bit of chicken-egg thing here -- I think we want to update the build system first, so we can use that in the gitHub actions ... Does anyone have a PR for updating the build already? (e.g. going to hatchling and uv). |
Ahh I see #126 -- but that's using PDM -- we want to go hatchling and UV, yes? |
In short, we can. Just my remark: the changes of this PR are mostly cosmetic and we don't need to wait for GHA workflows because, for instance, I cannot see any breaking changes. But if ideologically the GHA is the first thing, this PR can wait. |
Do you wanna go with the |
1b25638
to
bc18296
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we have a dependency problem:
ModuleNotFoundError: No module named 'dateutil'
Probably need to add an install step before running tests -- that should install the dependencies.
nice! |
fb7a1d6
to
fa00ac1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Partially covers: #126 - rearranging the tests
Partially addresses: #127