Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests directory to root level #129

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Conversation

stankudrow
Copy link
Contributor

Partially covers: #126 - rearranging the tests
Partially addresses: #127

@stankudrow stankudrow changed the title Move tests from code base to the project root level Place the tests directorty alongside the code Dec 17, 2024
@stankudrow stankudrow changed the title Place the tests directorty alongside the code Place the tests directory alongside the code Dec 18, 2024
tests/test_object.py Outdated Show resolved Hide resolved
@Kludex
Copy link
Member

Kludex commented Dec 18, 2024

Can we start the changes on the test with the GitHub actions running the test suite? So we are sure we don't break anything here...

@Kludex Kludex mentioned this pull request Dec 18, 2024
@ChrisBarker-NOAA
Copy link

Yes, we should -- I started working on that, but there's a bit of chicken-egg thing here -- I think we want to update the build system first, so we can use that in the gitHub actions ...

Does anyone have a PR for updating the build already? (e.g. going to hatchling and uv).

@ChrisBarker-NOAA
Copy link

Ahh I see #126 -- but that's using PDM -- we want to go hatchling and UV, yes?

@stankudrow
Copy link
Contributor Author

Can we start the changes on the test with the GitHub actions running the test suite? So we are sure we don't break anything here...

In short, we can.

Just my remark: the changes of this PR are mostly cosmetic and we don't need to wait for GHA workflows because, for instance, I cannot see any breaking changes. But if ideologically the GHA is the first thing, this PR can wait.

@stankudrow stankudrow requested a review from Kludex December 18, 2024 20:17
@stankudrow
Copy link
Contributor Author

Yes, we should -- I started working on that, but there's a bit of chicken-egg thing here -- I think we want to update the build system first, so we can use that in the gitHub actions ...

Does anyone have a PR for updating the build already? (e.g. going to hatchling and uv).

Do you wanna go with the uv or GHA? Let's split the work, both topics are interesting to me.

Copy link

@ChrisBarker-NOAA ChrisBarker-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we have a dependency problem:
ModuleNotFoundError: No module named 'dateutil'

Probably need to add an install step before running tests -- that should install the dependencies.

.github/workflows/main.yml Outdated Show resolved Hide resolved
tests/test_object.py Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@ChrisBarker-NOAA
Copy link

nice!

.github/workflows/main.yml Outdated Show resolved Hide resolved
@Kludex Kludex changed the title Place the tests directory alongside the code Move tests directory to root level Dec 19, 2024
Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Kludex Kludex merged commit 5a85a1c into py-bson:master Dec 19, 2024
6 checks passed
@stankudrow stankudrow deleted the make-tests-dir branch December 31, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants