-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Use mypy recursive type support #2898
base: main
Are you sure you want to change the base?
Conversation
In mypy>=1.7 recursive type support is built-in.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2898 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 52 52
Lines 8751 8751
Branches 1593 1593
=======================================
Hits 8433 8433
Misses 190 190
Partials 128 128 ☔ View full report in Codecov by Sentry. |
Is this failing because mypy==1.4.1 is being used in ci.txt? Fixable if |
These are docs build issues, not related to mypy. They might be fixed with a more recent sphinx version, but this requires further updates to other packages and the configuration file: #2573 (comment) I had planned to do this in the summer, but have been quite busy with more important tasks. I will try to find some time in the next weeks. |
Apparently Sphinx does not like recursive types. Does delayed evaluation with |
Thanks @stefan6419846. Upstream solution may be simplest, although is low priority. |
In mypy>=1.7 recursive type support is built-in.
In mypy>=1.7 recursive type support is built-in.
In mypy>=1.7 recursive type support is built-in.
In mypy>=1.7 recursive type support is built-in.
In mypy>=1.7 recursive type support is built-in.