Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Use mypy recursive type support #2898

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

MAINT: Use mypy recursive type support #2898

wants to merge 8 commits into from

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Oct 11, 2024

In mypy>=1.7 recursive type support is built-in.

In mypy>=1.7 recursive type support is built-in.
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.36%. Comparing base (27edc06) to head (050a09e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2898   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files          52       52           
  Lines        8751     8751           
  Branches     1593     1593           
=======================================
  Hits         8433     8433           
  Misses        190      190           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-t-1
Copy link
Contributor Author

j-t-1 commented Oct 11, 2024

Is this failing because mypy==1.4.1 is being used in ci.txt?

Fixable if pip-compile requirements/ci.in is run with Python 3.8?

@stefan6419846
Copy link
Collaborator

stefan6419846 commented Oct 11, 2024

These are docs build issues, not related to mypy. They might be fixed with a more recent sphinx version, but this requires further updates to other packages and the configuration file: #2573 (comment) I had planned to do this in the summer, but have been quite busy with more important tasks. I will try to find some time in the next weeks.

@stefan6419846
Copy link
Collaborator

Apparently Sphinx does not like recursive types. Does delayed evaluation with __future__.annotations work? Otherwise, we might have to look for a corresponding upstream issue or report one ourselves.

@j-t-1
Copy link
Contributor Author

j-t-1 commented Nov 15, 2024

Thanks @stefan6419846. Upstream solution may be simplest, although is low priority.

j-t-1 added 6 commits December 3, 2024 14:25
In mypy>=1.7 recursive type support is built-in.
In mypy>=1.7 recursive type support is built-in.
In mypy>=1.7 recursive type support is built-in.
In mypy>=1.7 recursive type support is built-in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants