-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compression and documentation options to netCDF exporter #352
Conversation
The failed tests seem to be unrelated to the changes in this PR. It is related to opencv, it seems, does something go wrong with the installation of that in some of the python versions? |
@RubenImhoff just to understand, did you fork this from master or from #351 ? |
This PR is forked from master, indeed (independent from #351) |
it should be fixed on master now, can you merge master into this branch @RubenImhoff to see if now tests pass? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
=======================================
Coverage 83.32% 83.33%
=======================================
Files 161 161
Lines 12363 12370 +7
=======================================
+ Hits 10302 10309 +7
Misses 2061 2061
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks, Daniele! I also added some tests, but couldn't find a way to assert if the passed new arguments also end up in the netCDF. If you know a way, let me know, otherwise this should be good as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the great contribution!
Improvement to netCDF exporter to add optional arguments scale, offset, fill_value and datatype for reduced storage possibilities. In addition, some kwargs are add to make it possible to add documentation or explanatory strings to the netCDF file.