Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compression and documentation options to netCDF exporter #352

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

RubenImhoff
Copy link
Contributor

Improvement to netCDF exporter to add optional arguments scale, offset, fill_value and datatype for reduced storage possibilities. In addition, some kwargs are add to make it possible to add documentation or explanatory strings to the netCDF file.

@RubenImhoff RubenImhoff added the enhancement New feature or request label Mar 27, 2024
@RubenImhoff RubenImhoff self-assigned this Mar 27, 2024
@RubenImhoff RubenImhoff requested review from dnerini and pulkkins March 27, 2024 17:37
@RubenImhoff
Copy link
Contributor Author

The failed tests seem to be unrelated to the changes in this PR. It is related to opencv, it seems, does something go wrong with the installation of that in some of the python versions?

@dnerini
Copy link
Member

dnerini commented Apr 3, 2024

@RubenImhoff just to understand, did you fork this from master or from #351 ?

@RubenImhoff
Copy link
Contributor Author

This PR is forked from master, indeed (independent from #351)

@dnerini
Copy link
Member

dnerini commented Apr 3, 2024

it should be fixed on master now, can you merge master into this branch @RubenImhoff to see if now tests pass?

@dnerini dnerini mentioned this pull request Apr 3, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.33%. Comparing base (bdfa575) to head (bc93143).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   83.32%   83.33%           
=======================================
  Files         161      161           
  Lines       12363    12370    +7     
=======================================
+ Hits        10302    10309    +7     
  Misses       2061     2061           
Flag Coverage Δ
unit_tests 83.33% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RubenImhoff
Copy link
Contributor Author

Thanks, Daniele! I also added some tests, but couldn't find a way to assert if the passed new arguments also end up in the netCDF. If you know a way, let me know, otherwise this should be good as is.

Copy link
Member

@dnerini dnerini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the great contribution!

@dnerini dnerini merged commit 1525178 into master Apr 4, 2024
10 checks passed
@dnerini dnerini deleted the improve_exporters branch April 4, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants