Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importers for new OPERA products #441

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Importers for new OPERA products #441

merged 6 commits into from
Dec 4, 2024

Conversation

pulkkins
Copy link
Member

Production of ODYSSEY radar composites from OPERA was discontinued on October 30th 2024. They have been replaced with CIRRUS and NIMBUS. This pull request contains

  • ODIM HDF5 importer with support for the new OPERA products (backward compatible with ODYSSEY)
  • updated test module for ODYSSEY, CIRRUS and NIMBUS

Example data from CIRRUS and NIMBUS has been uploaded here.

As stated here, the ODIM HDF5 importer should be able to read HDF5 files from DPC. Could someone add tests for those?

@pulkkins pulkkins self-assigned this Nov 29, 2024
@pulkkins pulkkins requested a review from dnerini November 29, 2024 08:59
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.17%. Comparing base (8b5333c) to head (11c04fe).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pysteps/io/importers.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   84.03%   84.17%   +0.14%     
==========================================
  Files         160      160              
  Lines       13031    13058      +27     
==========================================
+ Hits        10950    10991      +41     
+ Misses       2081     2067      -14     
Flag Coverage Δ
unit_tests 84.17% <94.59%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dnerini dnerini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking all good, thanks a lot @pulkkins for this contribution!

concerning the compatibility with DCP files, I suggest to open a separate issue.

@dnerini dnerini merged commit 50839ff into master Dec 4, 2024
10 checks passed
@dnerini dnerini deleted the opera_fixes branch December 4, 2024 19:42
@dnerini dnerini linked an issue Dec 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with PAAH22_C_EUOC new OPERA file
3 participants