Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor steps in blending code #443

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
2066f14
Refactored all names in the steps blending code from old to new
sidekock Nov 18, 2024
72d0fbc
Made some name changes but test still do not pass
sidekock Nov 18, 2024
1ce563e
Fixed naming changes, now the tests pass
sidekock Nov 18, 2024
fbe551b
Built the rough scaffolding for the blending class
sidekock Nov 18, 2024
46a93e5
Refactored untill no rain case
sidekock Nov 27, 2024
1eede39
Added code to estimation of ar parameters of radar
sidekock Nov 28, 2024
a18f1f6
Next go, start with forecast loop #7
sidekock Nov 29, 2024
8d16c11
Added some uniformity between nowcast and blending steps. Now at # 8.…
sidekock Dec 2, 2024
88df97d
Small changes since prev commit
sidekock Dec 2, 2024
7ee0020
All code is tranfered. Last part of the main loop needs to be refactored
sidekock Dec 2, 2024
f387981
Everything is refactored, no test ran as of yet
sidekock Dec 5, 2024
760c185
Old forecast function is updated to fit newly refactored code
sidekock Dec 5, 2024
8d8905a
Removed old code which is no longer used
sidekock Dec 5, 2024
d6249f5
6 more tests that fail
sidekock Dec 5, 2024
38702b3
All tests pass, still need to fix TODOs
sidekock Dec 5, 2024
5ff1713
Updated gitignore
sidekock Dec 5, 2024
d999501
Cleanup of params and state dataclasses, next step: better typing
sidekock Dec 6, 2024
ed20ecc
Cleanup of params and state dataclasses, now all tests pass
sidekock Dec 6, 2024
701e726
Added correct typing to all parts of params and state
sidekock Dec 6, 2024
b9de511
Ready for pull request
sidekock Dec 6, 2024
38ed195
Made changes for Codacy review
sidekock Dec 6, 2024
32b656f
Added aditional tests which currently fail in master branch
sidekock Dec 16, 2024
4fe9f78
Update .gitignore
sidekock Dec 16, 2024
b31d55c
Used the __zero_precip_time in __zero_precipitation_forecast()
sidekock Dec 16, 2024
cc02593
Changed typing hints to python 3.10+ version
sidekock Dec 16, 2024
4e4a148
Added comments back to the State dataclass
sidekock Dec 16, 2024
0f4e037
Changed the self.__state.velocity_perturbations = [] to self.__params…
sidekock Dec 17, 2024
9f413aa
Added code changes as suggested by Ruben, comments and documentation …
sidekock Dec 18, 2024
c72d953
Added frozen functionality to dataclasses, removed reset_state and fi…
sidekock Dec 19, 2024
00f057b
Added frozen dataclass to nowcast
sidekock Dec 19, 2024
1b82512
The needed checks are done for this TODO so it can be removed
sidekock Dec 19, 2024
47ab6c3
Use the seed in all rng in blending code (#449)
mats-knmi Jan 2, 2025
48187c4
Removed deepcopy of worker_state. The state is now accessable to all …
sidekock Jan 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,7 @@ venv.bak/

# Mac OS Stuff
.DS_Store

# Running local tests
/tmp
/pysteps/tests/tmp/
Loading
Loading