Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CI to build & push PyBaMM's Docker Images #3316

Merged
merged 21 commits into from
Oct 8, 2023
Merged

Create CI to build & push PyBaMM's Docker Images #3316

Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
50dcc4e
Create `docker.yml`
arjxn-py Sep 9, 2023
0fc4480
Basic config
arjxn-py Sep 9, 2023
20a720a
Add initial Checkout step
arjxn-py Sep 9, 2023
2be1537
Add docker login step
arjxn-py Sep 9, 2023
b611dd1
Build & push `pybamm:latest`
arjxn-py Sep 9, 2023
c399122
Build & push `pybamm:jax`
arjxn-py Sep 9, 2023
174db81
Build & push `pybamm:odes`
arjxn-py Sep 9, 2023
835a78f
Build & push `pybamm:idaklu`
arjxn-py Sep 9, 2023
02f7936
Build & push `pybamm:all`
arjxn-py Sep 9, 2023
c15f96f
Point to `develop`
arjxn-py Sep 9, 2023
e515c26
Merge branch 'develop' into docker-ci
arjxn-py Sep 21, 2023
193ce56
Login on dockerhub to test
arjxn-py Sep 21, 2023
f697bfe
Try pushing with `build-push-action`
arjxn-py Sep 28, 2023
0cd648a
Specify dockerfile path
arjxn-py Sep 28, 2023
bd740b7
Set up Docker Buildx
arjxn-py Sep 28, 2023
bcf4c60
Try name in tags
arjxn-py Sep 28, 2023
6f012f7
Push all images with `build-push-action`
arjxn-py Sep 28, 2023
cfc2a37
Add cron job [skip ci]
arjxn-py Oct 3, 2023
0256426
Merge to develop
arjxn-py Oct 3, 2023
2a88dfe
Push to docker on every push to develop
arjxn-py Oct 3, 2023
b059ebe
Merge branch 'develop' into docker-ci
arjxn-py Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 75 additions & 0 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
name: Build & Push Docker Images

on:
workflow_dispatch:
push:
branches:
- develop

jobs:
pre_job:
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Login to DockerHub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
arjxn-py marked this conversation as resolved.
Show resolved Hide resolved

- name: List built images
run: docker images

- name: Build and Push Docker Image (Without Solvers)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one also has the latest tag

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the earlier one (with all solvers) should have had the all tag. I do have a local branch which fixes things up a bit for this workflow (including logging in and uploading these images in parallel jobs) and will write a PR soon, I might look into adding the multi-platform images there itself.

uses: docker/build-push-action@v5
with:
context: .
file: scripts/Dockerfile
tags: pybamm/pybamm:latest
push: true

- name: Build and Push Docker Image (With JAX Solver)
uses: docker/build-push-action@v5
with:
context: .
file: scripts/Dockerfile
tags: pybamm/pybamm:jax
push: true
build-args: |
JAX=true

- name: Build and Push Docker Image (With ODES & DAE Solver)
uses: docker/build-push-action@v5
with:
context: .
file: scripts/Dockerfile
tags: pybamm/pybamm:odes
push: true
build-args: |
ODES=true

- name: Build and Push Docker Image (With IDAKLU Solver)
uses: docker/build-push-action@v5
with:
context: .
file: scripts/Dockerfile
tags: pybamm/pybamm:idaklu
push: true
build-args: |
IDAKLU=true

- name: Build and Push Docker Image (With All Solvers)
uses: docker/build-push-action@v5
with:
context: .
file: scripts/Dockerfile
tags: pybamm/pybamm:latest
Comment on lines +67 to +72
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we did not tag the images properly. On https://hub.docker.com/r/pybamm/pybamm/tags I can see that this image was pushed with the latest tag, and

push: true
build-args: |
ALL=true
Loading