error_already_set::what() is now constructed lazily#1895

Merged

rwgk merged 136 commits intopybind:masterfrom superbobry:lazy-error-string

Jun 2, 2022

+272-120

Commits on Aug 29, 2019

Commits on Feb 13, 2022

Commits on Feb 14, 2022

Commits on Feb 16, 2022

Does reverting this fix PyPy
Skylion007
committed

Commits on Feb 20, 2022

Commits on Feb 22, 2022

Commits on Mar 2, 2022

Commits on Apr 23, 2022

t pushMerge branch 'master' of https://github.com/pybind/pybind11 into lazy-error-string
Skylion007
committed

Commits on Apr 24, 2022

Abuse assignment operator
Skylion007
committed

Commits on May 3, 2022

Revert operator abuse
Skylion007
committed

Commits on May 4, 2022

Commits on May 5, 2022

Merge branch 'master' into lazy-error-string
Ralf W. Grosse-Kunstleve
committed
Report "FATAL failure building pybind11::error_already_set error_string" and terminate process.
Ralf W. Grosse-Kunstleve
committed

Commits on May 6, 2022

Commits on May 10, 2022

Merge branch 'master' into lazy-error-string
Ralf W. Grosse-Kunstleve
committed
Merge branch 'lazy-error-string' of https://github.com/superbobry/pybind11 into lazy-error-string
Ralf W. Grosse-Kunstleve
committed
detail::obj_class_name(), fprintf with [STDERR], [STDOUT] tags, polish comments
Ralf W. Grosse-Kunstleve
committed

Commits on May 11, 2022

consistently check m_lazy_what.empty() also in production builds
Ralf W. Grosse-Kunstleve
committed
Make a comment slightly less ambiguous.
Ralf W. Grosse-Kunstleve
committed
Bug fix: Remove what(); from restore().
Ralf W. Grosse-Kunstleve
committed
Replace extremely opaque (unhelpful) error message with a truthful reflection of what we know.
Ralf W. Grosse-Kunstleve
committed
Fix clang-tidy error [performance-move-constructor-init].
Ralf W. Grosse-Kunstleve
committed
Make expected error message less specific.
Ralf W. Grosse-Kunstleve
committed
Various changes.
Ralf W. Grosse-Kunstleve
committed
bug fix: error_string(PyObject **, ...)
Ralf W. Grosse-Kunstleve
committed

Commits on May 12, 2022

Putting back the two eager PyErr_NormalizeException() calls.
Ralf W. Grosse-Kunstleve
committed
Change error_already_set() to call pybind11_fail() if the Python error indicator not set. The net result is that a std::runtime_error is thrown instead of error_already_set, but all tests pass as is.
Ralf W. Grosse-Kunstleve
committed
Remove mutable (fixes oversight in the previous commit).
Ralf W. Grosse-Kunstleve
committed
Normalize the exception only locally in error_string(). Python 3.6 & 3.7 test failures expected. This is meant for benchmarking, to determine if it is worth the trouble looking into the failures.
Ralf W. Grosse-Kunstleve
committed
clang-tidy: use auto
Ralf W. Grosse-Kunstleve
committed
Use gil_scoped_acquire_local in error_already_set destructor. See long comment.
Ralf W. Grosse-Kunstleve
committed
For Python < 3.8: PyErr_NormalizeException before PyErr_WriteUnraisable
Ralf W. Grosse-Kunstleve
committed

Commits on May 13, 2022

Go back to replacing the held Python exception with then normalized exception, if & when needed. Consistently document the side-effect.
Ralf W. Grosse-Kunstleve
committed
Slightly rewording comment. (There were also other failures.)
Ralf W. Grosse-Kunstleve
committed
Add 1-line comment for obj_class_name()
Ralf W. Grosse-Kunstleve
committed
Benchmark code, with results in this commit message.
Ralf W. Grosse-Kunstleve
committed
Changing call_repetitions_target_elapsed_secs to 0.1 for regular unit testing.
Ralf W. Grosse-Kunstleve
committed

Commits on May 14, 2022

Adding in recursion_depth
Ralf W. Grosse-Kunstleve
committed
Optimized ctor
Skylion007
committed
Merge branch 'lazy-error-string' of https://github.com/superbobry/pybind11 into lazy-error-string
Skylion007
committed

Commits on May 15, 2022

Fix silly bug in recurse_first_then_call()
Ralf W. Grosse-Kunstleve
committed
Add tests that have equivalent PyErr_Fetch(), PyErr_Restore() but no try-catch.
Ralf W. Grosse-Kunstleve
committed
Add call_error_string to tests. Sample only recursion_depth 0, 100.
Ralf W. Grosse-Kunstleve
committed
Show lazy-what speed-up in percent.
Ralf W. Grosse-Kunstleve
committed
Include real_work in benchmarks.
Ralf W. Grosse-Kunstleve
committed

Commits on May 16, 2022

Replace all PyErr_SetString() with generate_python_exception_with_traceback()
Ralf W. Grosse-Kunstleve
committed
Better organization of test loops.
Ralf W. Grosse-Kunstleve
committed
Add test_error_already_set_copy_move
Ralf W. Grosse-Kunstleve
committed
Fix bug in newly added test (discovered by clang-tidy): actually use move ctor
Ralf W. Grosse-Kunstleve
committed
MSVC detects the unreachable return
Ralf W. Grosse-Kunstleve
committed

Commits on May 17, 2022

change test_perf_error_already_set.py back to quick mode
Ralf W. Grosse-Kunstleve
committed
Inherit from std::exception (instead of std::runtime_error, which does not make sense anymore with the lazy what)
Ralf W. Grosse-Kunstleve
committed
Special handling under Windows.
Ralf W. Grosse-Kunstleve
committed
print with leading newline
Ralf W. Grosse-Kunstleve
committed
Merge branch 'master' into lazy-error-string
Ralf W. Grosse-Kunstleve
committed

Commits on May 18, 2022

Removing test_perf_error_already_set (copies are under rwgk/rwgk_tbx@7765113).
Ralf W. Grosse-Kunstleve
committed
Avoid gil and scope overhead if there is nothing to release.
Ralf W. Grosse-Kunstleve
committed
Restore default move ctor. "member function" instead of "function" (note that "method" is Python terminology).
Ralf W. Grosse-Kunstleve
committed
Delete error_already_set copy ctor.
Ralf W. Grosse-Kunstleve
committed
Make restore() non-const again to resolve clang-tidy failure (still experimenting).
Ralf W. Grosse-Kunstleve
committed
Bring back error_already_set copy ctor, to see if that resolves the 4 MSVC test failures.
Ralf W. Grosse-Kunstleve
committed
Add noexcept to error_already_set copy & move ctors (as suggested by @Skylion007 IIUC).
Ralf W. Grosse-Kunstleve
committed
Trying one-by-one noexcept copy ctor for old compilers.
Ralf W. Grosse-Kunstleve
committed
Add back test covering copy ctor. Add another simple test that exercises the copy ctor.
Ralf W. Grosse-Kunstleve
committed

Commits on May 19, 2022

Exclude more older compilers from using the noexcept = default ctors. (The tests in the previous commit exposed that those are broken.)
Ralf W. Grosse-Kunstleve
committed
Factor out & reuse gil_scoped_acquire_local as gil_scoped_acquire_simple
Ralf W. Grosse-Kunstleve
committed
Guard gil_scoped_acquire_simple by _Py_IsFinalizing() check.
Ralf W. Grosse-Kunstleve
committed
what() GIL safety
Ralf W. Grosse-Kunstleve
committed
clang-tidy & Python 3.6 fixes
Ralf W. Grosse-Kunstleve
committed

Commits on May 20, 2022

Merge branch 'master' into lazy-error-string
Ralf W. Grosse-Kunstleve
committed
Use gil_scoped_acquire in dtor, copy ctor, what(). Remove _Py_IsFinalizing() checks (they are racy: python/cpython#28525 ).
Ralf W. Grosse-Kunstleve
committed

Commits on May 21, 2022

Remove error_scope from copy ctor.
Ralf W. Grosse-Kunstleve
committed
Add error_scope to get_internals(), to cover the situation that get_internals() is called from the error_already_set dtor while a new Python error is in flight already. Also backing out `gi…
Ralf W. Grosse-Kunstleve
committed

Commits on May 23, 2022

Add FlakyException tests with failure triggers in __init__ and __str__
Ralf W. Grosse-Kunstleve
committed

Commits on May 24, 2022

Tweaks to resolve Py 3.6 and PyPy CI failures.
Ralf W. Grosse-Kunstleve
committed
Normalize Python exception immediately in error_already_set ctor.
Ralf W. Grosse-Kunstleve
committed
Merge branch 'master' into lazy-error-string
Ralf W. Grosse-Kunstleve
committed
Fix oversights based on CI failures (copy & move ctor initialization).
Ralf W. Grosse-Kunstleve
committed
Move @pytest.mark.xfail("env.PYPY") after @pytest.mark.parametrize(...)
Ralf W. Grosse-Kunstleve
committed
Use @pytest.mark.skipif (xfail does not work for segfaults, of course).
Ralf W. Grosse-Kunstleve
committed

Commits on May 31, 2022

Merge branch 'master' into lazy-error-string
Ralf W. Grosse-Kunstleve
committed

Commits on Jun 1, 2022

Remove unused obj_class_name_or() function (it was added only under this PR).
Ralf W. Grosse-Kunstleve
committed
Remove already obsolete C++ comments and code that were added only under this PR.
Ralf W. Grosse-Kunstleve
committed
Slightly better (newly added) comments.
Ralf W. Grosse-Kunstleve
committed
Factor out detail::error_fetch_and_normalize. Preparation for producing identical results from error_already_set::what() and detail::error_string(). Note that this is a very conservative refactorin…
Ralf W. Grosse-Kunstleve
committed
Copy most of error_string() code to new error_fetch_and_normalize::complete_lazy_error_string()
Ralf W. Grosse-Kunstleve
committed
Remove all error_string() code from detail/type_caster_base.h. Note that this commit includes a subtle bug fix: previously error_string() restored the Python error, which will upset pybind11_fail()…
Ralf W. Grosse-Kunstleve
committed
Return const std::string& instead of const char * and move error_string() to pytypes.h
Ralf W. Grosse-Kunstleve
committed
Remove gil_scope_acquire from error_fetch_and_normalize, add back to error_already_set
Ralf W. Grosse-Kunstleve
committed
Better handling of FlakyException __str__ failure.
Ralf W. Grosse-Kunstleve
committed
Move error_fetch_and_normalize::complete_lazy_error_string() implementation from pybind11.h to pytypes.h
Ralf W. Grosse-Kunstleve
committed
Add error_fetch_and_normalize::release_py_object_references() and use from error_already_set dtor.
Ralf W. Grosse-Kunstleve
committed
Use shared_ptr for m_fetched_error => 1. non-racy, copy ctor that does not need the GIL; 2. enables guard against duplicate restore() calls.
Ralf W. Grosse-Kunstleve
committed
Add comments.
Ralf W. Grosse-Kunstleve
committed
Trivial renaming of a newly introduced member function.
Ralf W. Grosse-Kunstleve
committed
Merge branch 'master' into lazy-error-string
Ralf W. Grosse-Kunstleve
committed
Workaround for PyPy
Ralf W. Grosse-Kunstleve
committed
Bug fix (oversight). Only valgrind got this one.
Ralf W. Grosse-Kunstleve
committed

Commits on Jun 2, 2022

Use shared_ptr custom deleter for m_fetched_error in error_already_set. This enables removing the dtor, copy ctor, move ctor completely.
Ralf W. Grosse-Kunstleve
committed
Further small simplification. With the GIL held, simply deleting the raw_ptr takes care of everything.
Ralf W. Grosse-Kunstleve
committed
IWYU cleanup
Ralf W. Grosse-Kunstleve
committed